Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752455AbdFMKVt (ORCPT ); Tue, 13 Jun 2017 06:21:49 -0400 Received: from ozlabs.org ([103.22.144.67]:40819 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbdFMKVr (ORCPT ); Tue, 13 Jun 2017 06:21:47 -0400 From: Michael Ellerman To: Masahiro Yamada , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Anatolij Gustschin Cc: Masahiro Yamada , devicetree@vger.kernel.org, Linux Kernel Mailing List , Rob Herring , Mark Rutland Subject: Re: [PATCH] powerpc: dts: use #include "..." to include local DT In-Reply-To: References: <1495602744-18874-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 13 Jun 2017 20:21:45 +1000 Message-ID: <87r2yogpc6.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2376 Lines: 86 Masahiro Yamada writes: > Hi > > (+Anatolij Gustschin ) > > > Ping. > I am not 100% sure who is responsible for this, > but somebody, could take a look at this patch, please? Have you tested it actually works? It sounds reasonable, and if it behaves as you describe there is no change in behaviour, right? cheers > 2017-05-24 14:12 GMT+09:00 Masahiro Yamada : >> Most of DT files in PowerPC use #include "..." to make pre-processor >> include DT in the same directory, but we have 3 exceptional files >> that use #include <...> for that. >> >> Fix them to remove -I$(srctree)/arch/$(SRCARCH)/boot/dts path from >> dtc_cpp_flags. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> arch/powerpc/boot/dts/ac14xx.dts | 2 +- >> arch/powerpc/boot/dts/mpc5121ads.dts | 2 +- >> arch/powerpc/boot/dts/pdm360ng.dts | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/powerpc/boot/dts/ac14xx.dts b/arch/powerpc/boot/dts/ac14xx.dts >> index 27fcabc2f857..83bcfd865167 100644 >> --- a/arch/powerpc/boot/dts/ac14xx.dts >> +++ b/arch/powerpc/boot/dts/ac14xx.dts >> @@ -10,7 +10,7 @@ >> */ >> >> >> -#include >> +#include "mpc5121.dtsi" >> >> / { >> model = "ac14xx"; >> diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts >> index 75888ce2c792..73c30621429b 100644 >> --- a/arch/powerpc/boot/dts/mpc5121ads.dts >> +++ b/arch/powerpc/boot/dts/mpc5121ads.dts >> @@ -9,7 +9,7 @@ >> * option) any later version. >> */ >> >> -#include >> +#include "mpc5121.dtsi" >> >> / { >> model = "mpc5121ads"; >> diff --git a/arch/powerpc/boot/dts/pdm360ng.dts b/arch/powerpc/boot/dts/pdm360ng.dts >> index 0cec7244abe7..445b88114009 100644 >> --- a/arch/powerpc/boot/dts/pdm360ng.dts >> +++ b/arch/powerpc/boot/dts/pdm360ng.dts >> @@ -13,7 +13,7 @@ >> * option) any later version. >> */ >> >> -#include >> +#include "mpc5121.dtsi" >> >> / { >> model = "pdm360ng"; >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > Best Regards > Masahiro Yamada