Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753156AbdFMKlK (ORCPT ); Tue, 13 Jun 2017 06:41:10 -0400 Received: from aer-iport-4.cisco.com ([173.38.203.54]:46444 "EHLO aer-iport-4.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbdFMKlJ (ORCPT ); Tue, 13 Jun 2017 06:41:09 -0400 X-Greylist: delayed 595 seconds by postgrey-1.27 at vger.kernel.org; Tue, 13 Jun 2017 06:41:09 EDT X-IronPort-AV: E=Sophos;i="5.39,337,1493683200"; d="scan'208";a="655383633" Subject: Re: [PATCH 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver To: Jose Abreu , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <22ea8b160edaef464d7f5ad362b23a68a6e07633.1497347657.git.joabreu@synopsys.com> Cc: Carlos Palminha , Hans Verkuil From: Hans Verkuil Message-ID: Date: Tue, 13 Jun 2017 12:31:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Authenticated-User: hansverk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 58 On 06/13/17 12:06, Jose Abreu wrote: > Hi Hans, > > > On 13-06-2017 11:01, Jose Abreu wrote: > > [snip] >> Changes from RFC: >> - Added support for HDCP 1.4 > > [snip] >> + >> +/* HDCP 1.4 */ >> +#define DW_HDMI_HDCP14_BKSV_SIZE 2 >> +#define DW_HDMI_HDCP14_KEYS_SIZE (2 * 40) >> + >> +struct dw_hdmi_hdcp14_key { >> + u32 seed; >> + u32 bksv[DW_HDMI_HDCP14_BKSV_SIZE]; >> + u32 keys[DW_HDMI_HDCP14_KEYS_SIZE]; >> + bool keys_valid; >> +}; >> + >> +struct dw_hdmi_rx_pdata { >> + /* Controller configuration */ >> + unsigned int iref_clk; /* MHz */ >> + struct dw_hdmi_hdcp14_key hdcp14_keys; >> + /* 5V sense interface */ >> + bool (*dw_5v_status)(void __iomem *regs, int input); >> + void (*dw_5v_clear)(void __iomem *regs); >> + void __iomem *dw_5v_arg; >> + /* Zcal interface */ >> + void (*dw_zcal_reset)(void __iomem *regs); >> + bool (*dw_zcal_done)(void __iomem *regs); >> + void __iomem *dw_zcal_arg; >> +}; >> + >> +#endif /* __DW_HDMI_RX_PDATA_H__ */ > > I now have support for HDCP 1.4 in this driver. Can you send me > the patches about HDCP that you mentioned a while ago? This is what I have: https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=hdcp This is very old and somewhat messy. It uses ioctls for the bksv's, but I wonder if array/compound controls wouldn't be more appropriate (those didn't exist when this was written originally). It also needs to be checked against HDCP 2 so it can support that as well (or at least be easily extended for that). Regards, Hans