Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753252AbdFMNXT (ORCPT ); Tue, 13 Jun 2017 09:23:19 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:23235 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752695AbdFMNXS (ORCPT ); Tue, 13 Jun 2017 09:23:18 -0400 Message-ID: <1497360189.930.42.camel@mhfsdcap03> Subject: Re: [PATCH v4 2/2] arm: dts: Add Mediatek MT2701 i2c device node From: Jun Gao To: Matthias Brugger CC: Wolfram Sang , , , , , , Date: Tue, 13 Jun 2017 21:23:09 +0800 In-Reply-To: References: <1495784107-6711-1-git-send-email-jun.gao@mediatek.com> <1495784107-6711-3-git-send-email-jun.gao@mediatek.com> <1497268468.930.26.camel@mhfsdcap03> <1497349452.930.36.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1844 Lines: 63 On Tue, 2017-06-13 at 14:52 +0200, Matthias Brugger wrote: > > On 13/06/17 12:24, Jun Gao wrote: > > On Tue, 2017-06-13 at 11:36 +0200, Matthias Brugger wrote: > >> > >> On 12/06/17 13:54, Jun Gao wrote: > >>> On Fri, 2017-05-26 at 15:35 +0800, Jun Gao wrote: > >>>> From: Jun Gao > >>>> > >>>> Add MT2701 i2c device node. > >>>> > >>>> Signed-off-by: Jun Gao > >>>> --- > >>>> arch/arm/boot/dts/mt2701-evb.dts | 42 ++++++++++++++++++++++++++++++++++++++++ > >>>> arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++ > >>>> 2 files changed, 84 insertions(+) > >> [...] > >>> > >>> Dear Matthias, > >>> > >>> Could you take this patch together with > >>> [PATCH v4 1/2]dt-bindings: i2c: Add Mediatek MT2701 i2c binding ? > >>> > >>> Thanks! > >>> > >> > >> They are both included in the pull request I send [1] [2], or do I miss > >> something? > >> > >> Regards, > >> Matthias > >> > >> [1] > >> https://github.com/mbgg/linux-mediatek/commit/729b7f8dbdaff270c53052897ea06486221a49a2 > >> [2] > >> https://github.com/mbgg/linux-mediatek/commit/c6c301d3ff7531894257acc4f4a73928a109bda1 > > > > Dear Matthias, > > > > Would you mind to use the same style as follows in i2c-mtk.txt of [2]? > > > > "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > > "mediatek,mt6577-i2c": for Mediatek MT6577 > > "mediatek,mt6589-i2c": for Mediatek MT6589 > > "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > > "mediatek,mt8173-i2c": for Mediatek MT8173 > > > > > > Thanks! > > > > You mean I should fix-up the patch to fit to the new binding > description? Or do you mean it should be MTxxxx instead of mtxxxx? > > Regards, > Matthias Dear Matthias, I mean fix-up the patch to fit to the new binding description. Is it OK? Thanks!