Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753277AbdFMNgm (ORCPT ); Tue, 13 Jun 2017 09:36:42 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:35864 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752781AbdFMNgk (ORCPT ); Tue, 13 Jun 2017 09:36:40 -0400 MIME-Version: 1.0 In-Reply-To: <1497264376-18840-2-git-send-email-fabian.wolff@fau.de> References: <1497264376-18840-1-git-send-email-fabian.wolff@fau.de> <1497264376-18840-2-git-send-email-fabian.wolff@fau.de> From: Ian W MORRISON Date: Tue, 13 Jun 2017 23:36:39 +1000 Message-ID: Subject: Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators To: Fabian Wolff Cc: linux-kernel@i4.cs.fau.de, horvatmate@gmail.com, devel@driverdev.osuosl.org, Greg KH , linux-kernel@vger.kernel.org, Hans de Goede Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2737 Lines: 71 On 12 June 2017 at 20:46, Fabian Wolff wrote: > This patch adds spaces around the binary operators '-' and '+', which > is the preferred style, and reformats a pointer argument declaration > to fix a false positive "spaces preferred around that '*'" message > reported by checkpatch.pl. > > Signed-off-by: Fabian Wolff > Signed-off-by: Mate Horvath > --- > drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c > index 9c61125..803eab0 100644 > --- a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c > +++ b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c > @@ -20,7 +20,7 @@ > > /* 2G chan 01 - chan 11 */ > #define RTW_2GHZ_CH01_11 \ > - REG_RULE(2412-10, 2462+10, 40, 0, 20, 0) > + REG_RULE(2412 - 10, 2462 + 10, 40, 0, 20, 0) > > /* > *We enable active scan on these a case > @@ -29,12 +29,12 @@ > > /* 2G chan 12 - chan 13, PASSIV SCAN */ > #define RTW_2GHZ_CH12_13 \ > - REG_RULE(2467-10, 2472+10, 40, 0, 20, \ > + REG_RULE(2467 - 10, 2472 + 10, 40, 0, 20, \ > NL80211_RRF_PASSIVE_SCAN) > > /* 2G chan 14, PASSIVS SCAN, NO OFDM (B only) */ > #define RTW_2GHZ_CH14 \ > - REG_RULE(2484-10, 2484+10, 40, 0, 20, \ > + REG_RULE(2484 - 10, 2484 + 10, 40, 0, 20, \ > NL80211_RRF_PASSIVE_SCAN | NL80211_RRF_NO_OFDM) > The construct 'freq_start-10, freq_end+10' is consistent with other drivers e.g. drivers/net/wireless/mac80211_hwsim.c drivers/net/wireless/broadcom/brcm80211/brcmsmac/channel.c:#define drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c drivers/net/wireless/realtek/rtlwifi/regd.c drivers/net/wireless/ath/regd.c and looks better (to me) without the inserted spaces. If the change is required will the other drivers be 'corrected'? > static const struct ieee80211_regdomain rtw_regdom_rd = { > @@ -116,8 +116,8 @@ static int _rtw_reg_notifier_apply(struct wiphy *wiphy, > } > > static const struct ieee80211_regdomain *_rtw_regdomain_select(struct > - rtw_regulatory > - *reg) > + rtw_regulatory * > + reg) > { > return &rtw_regdom_rd; > } > -- > 2.7.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel