Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbdFMNnk (ORCPT ); Tue, 13 Jun 2017 09:43:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56630 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369AbdFMNnj (ORCPT ); Tue, 13 Jun 2017 09:43:39 -0400 Date: Tue, 13 Jun 2017 15:43:30 +0200 From: Greg KH To: Wei Yang Cc: linux-kernel@vger.kernel.org, mhocko@kernel.org Subject: Re: [PATCH] base/memory: pass the base_section in add_memory_block Message-ID: <20170613134330.GB4769@kroah.com> References: <20170607085212.9765-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170607085212.9765-1-richard.weiyang@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 632 Lines: 19 On Wed, Jun 07, 2017 at 04:52:12PM +0800, Wei Yang wrote: > The second parameter of init_memory_block() is used to calculate the > start_section_nr of this block, which means any section in the same block > would get the same start_section_nr. > > This patch passes the base_section to init_memory_block(), so that to > reduce a local variable and a check in every loop. > > Signed-off-by: Wei Yang > --- > drivers/base/memory.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Can you resend this and cc: linux-mm? I think the developers there need to review this. thanks, greg k-h