Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753476AbdFMOnp (ORCPT ); Tue, 13 Jun 2017 10:43:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:47682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753311AbdFMOnm (ORCPT ); Tue, 13 Jun 2017 10:43:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9D6E239E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: References: <20170607103242.16008-1-enric.balletbo@collabora.com> <20170609140309.zhagc5g662d4la3z@rob-hp-laptop> From: Rob Herring Date: Tue, 13 Jun 2017 09:43:20 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: tps65217: Update binding documentation. To: Enric Balletbo Serra Cc: Enric Balletbo i Serra , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , linux-kernel , Linux LED Subsystem , "linux-input@vger.kernel.org" , Dmitry Torokhov , Lee Jones , Daniel Thompson , Jingoo Han , Richard Purdie , Jacek Anaszewski , Pavel Machek , Mark Rutland , Russell King , Tony Lindgren , Javier Martinez Canillas Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2368 Lines: 73 On Fri, Jun 9, 2017 at 5:30 PM, Enric Balletbo Serra wrote: > Hello Rob, > > 2017-06-09 16:03 GMT+02:00 Rob Herring : >> On Wed, Jun 07, 2017 at 12:32:39PM +0200, Enric Balletbo i Serra wrote: >>> This patch adds a new binding documentation for the TPS65217 MFD and >>> updates the documentation for all the sub-devices in accordance to get >>> each individual sub-driver functioning correctly. >> >> Explain why breaking compatibility is okay. >> > > We had some discussion in patch 4 that make me rethink a bit all this, > please let me send a new version and continue the discussion there > (now I'm not sure if I'll break the compatibility or not) > > But let me ask a question. The TPS65217 MFD has different sub-nodes > (charger, backlight, pwrbutton, regulators) in DT, I suspect the > answer is no, but is it ok that some of them were not described in the > DT because there is nothing to configure? But you are configuring the interrupts. I'm all for not creating nodes just for the purpose instantiating a driver (DT is not the only way to create platform devices) when the parent node is sufficient. We see both models, but we don't really want a mixture of both ways so I'd stick with the latter here. > i.e: Have this because the resources of charger and pwrbutton are > static so can be hard-coded in the driver > > &tps { > compatible = "ti,tps65217"; > interrupt-controller; > #interrupt-cells = <1>; > > regulators { > #address-cells = <1>; > #size-cells = <0>; > > dcdc1_reg: regulator@0 { > reg = <0>; > ... > }; > }; > > instead of : > > &tps { > compatible = "ti,tps65217"; > interrupt-controller; > #interrupt-cells = <1>; > > charger { > compatible = "ti,tps65217-charger"; > interrupts = <0>, <1>; > interrupt-names = "USB", "AC"; > }; > > pwrbutton { > compatible = "ti,tps65217-pwrbutton"; > interrupts = <2>; > }; > > regulators { > #address-cells = <1>; > #size-cells = <0>; > > dcdc1_reg: regulator@0 { > reg = <0>; > ... > }; > };