Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753521AbdFMPeP (ORCPT ); Tue, 13 Jun 2017 11:34:15 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41986 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752781AbdFMPeN (ORCPT ); Tue, 13 Jun 2017 11:34:13 -0400 Date: Tue, 13 Jun 2017 11:34:11 -0400 (EDT) Message-Id: <20170613.113411.506760268959654820.davem@davemloft.net> To: michael.j.dilmore@gmail.com Cc: j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add printk for bonding module packets_per_slave parameter From: David Miller In-Reply-To: <20170613134246.6407-1-michael.j.dilmore@gmail.com> References: <20170613134246.6407-1-michael.j.dilmore@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 13 Jun 2017 07:52:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 21 From: Michael Dilmore Date: Tue, 13 Jun 2017 14:42:46 +0100 > The packets per slave parameter used by round robin mode does not have a printk debug > message in its set function in bond_options.c. Adding such a function would aid debugging > of round-robin mode and allow the user to more easily verify that the parameter has been > set correctly. I should add that I'm motivated by my own experience here - it's not > obvious from output of tools such as wireshark and ifstat that the parameter is working > correctly, and with the differences in bonding configuration across different distributions, > it would have been comforting to see this output. > > Signed-off-by: Michael Dilmore > > cc: Veaceslav Falico ,Andy Gospodarek ,netdev@vger.kernel.org,linux-kernel@vger.kernel.org You can verify things by simplying reading the value back. If every parameter emitted a kernel log message, it would be unreadable. I'm not applying this, sorry.