From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kys@microsoft.com" <kys@microsoft.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "sthemmin@microsoft.com" <sthemmin@microsoft.com>,
        "longli@exchange.microsoft.com" <longli@exchange.microsoft.com>,
        "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
        "haiyangz@microsoft.com" <haiyangz@microsoft.com>
CC: "jthumshirn@suse.de" <jthumshirn@suse.de>,
        "longli@microsoft.com" <longli@microsoft.com>
Subject: Re: [Possible Phish Fraud][PATCH] storvsc: use default I/O timeout
 handler for FC devices
Thread-Topic: [Possible Phish Fraud][PATCH] storvsc: use default I/O timeout
 handler for FC devices
Thread-Index: AQHS4+LURlY8XkNqGkmxVZKj+nmEFaIi7lIA
Date: Tue, 13 Jun 2017 15:38:06 +0000
Message-ID: <1497368284.2804.5.camel@wdc.com>
References: <1497313417-14815-1-git-send-email-longli@exchange.microsoft.com>
In-Reply-To: <1497313417-14815-1-git-send-email-longli@exchange.microsoft.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <9BBCA72B0E716848B9E338A33774AAB2@namprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2017 15:38:06.0850
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5DFcML5026843
Content-Length: 1868
Lines: 59

On Mon, 2017-06-12 at 17:23 -0700, Long Li wrote:
> From: Long Li <longli@microsoft.com>
> 
> FC disks are usually setup in a multipath system, and they don't want to 
> unconditionaly reset I/O on timeout. I/O timeout is detected by multipath 
> as a good time to failover and recover.
> 
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
>  drivers/scsi/storvsc_drv.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 8d955db..d60b5ea 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -486,6 +486,7 @@ struct hv_host_device {
>  	unsigned int port;
>  	unsigned char path;
>  	unsigned char target;
> +	bool is_fc;
>  };
>  
>  struct storvsc_scan_work {
> @@ -1495,6 +1496,11 @@ static int storvsc_host_reset_handler(struct scsi_cmnd *scmnd)
>   */
>  static enum blk_eh_timer_return storvsc_eh_timed_out(struct scsi_cmnd *scmnd)
>  {
> +	struct hv_host_device *host_dev = shost_priv(scmnd->device->host);
> +
> +	if (host_dev->is_fc)
> +		return BLK_EH_NOT_HANDLED;
> +
>  	return BLK_EH_RESET_TIMER;
>  }
>  
> @@ -1738,6 +1744,7 @@ static int storvsc_probe(struct hv_device *device,
>  
>  	host_dev->port = host->host_no;
>  	host_dev->dev = device;
> +	host_dev->is_fc = is_fc;
>  
>  
>  	stor_device = kzalloc(sizeof(struct storvsc_device), GFP_KERNEL);

Hello Long,

As far as I know there is no other SCSI driver nor block driver in the Linux
kernel tree that returns BLK_EH_RESET_TIMER unconditionally. Would a valid
alternative fix be to remove storvsc_eh_timed_out() entirely? If not, what
would break if that function would be removed entirely?

Additionally, for FC, shouldn't that timeout handler handle the "port blocked"
state? Shouldn't fc_eh_timed_out() be used for FC instead of just returning
BLK_EH_NOT_HANDLED?

Thanks,

Bart.