Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753447AbdFMRO6 convert rfc822-to-8bit (ORCPT ); Tue, 13 Jun 2017 13:14:58 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:8276 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751822AbdFMRO4 (ORCPT ); Tue, 13 Jun 2017 13:14:56 -0400 From: Salil Mehta To: "Mintz, Yuval" , "davem@davemloft.net" CC: "Zhuangyuzeng (Yisen)" , huangdaode , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm Subject: RE: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Thread-Topic: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Thread-Index: AQHS4Zxj8bSA6mPXhEi8m9h1uQZm/6Id6++AgAUgS3A= Date: Tue, 13 Jun 2017 17:14:29 +0000 Message-ID: References: <20170610034630.493852-1-salil.mehta@huawei.com> <20170610034630.493852-9-salil.mehta@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.160] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.59401D8B.027F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.104, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5f95e8c5e18e0aba743d3fcc2e708def Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 31 HI Yuval, > -----Original Message----- > From: Mintz, Yuval [mailto:Yuval.Mintz@cavium.com] > Sent: Saturday, June 10, 2017 1:52 PM > To: Salil Mehta; davem@davemloft.net > Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Linuxarm > Subject: RE: [PATCH net-next 8/9] net: hns3: Add support of debugfs > interface to HNS3 driver > > > This adds the support of the debugfs interface to the driver for > debugging > > purposes. > > > +const struct hclge_support_cmd support_cmd[] = { > > + {"send cmd", 8, hclge_dbg_send, > > + "opcode flag data0 data1 data2 data3 data4 data5"}, > > + {"help", 4, hclge_dbg_usage, "no option"}, }; > > Is there an actual description of what this does? Or is it simply a > huge backdoor? Yes, I understand it has been coded in haste to assist in debugging of the driver. Yes, there is a format to it but needs bit of work I guess, otherwise it will be like opening pandoras box. For now, I will drop this debugfs patch and later will push with proper explanation of its need and interface. Thanks Salil