Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753744AbdFMRQb convert rfc822-to-8bit (ORCPT ); Tue, 13 Jun 2017 13:16:31 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:8277 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbdFMRQ2 (ORCPT ); Tue, 13 Jun 2017 13:16:28 -0400 From: Salil Mehta To: Andrew Lunn , "Mintz, Yuval" CC: "davem@davemloft.net" , "Zhuangyuzeng (Yisen)" , huangdaode , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm Subject: RE: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Thread-Topic: [PATCH net-next 8/9] net: hns3: Add support of debugfs interface to HNS3 driver Thread-Index: AQHS4Zxj8bSA6mPXhEi8m9h1uQZm/6Id6++AgAA+fICABOOWYA== Date: Tue, 13 Jun 2017 17:16:06 +0000 Message-ID: References: <20170610034630.493852-1-salil.mehta@huawei.com> <20170610034630.493852-9-salil.mehta@huawei.com> <20170610163535.GC26740@lunn.ch> In-Reply-To: <20170610163535.GC26740@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.160] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.59401DE6.0029,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.104, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5f95e8c5e18e0aba743d3fcc2e708def Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1149 Lines: 37 Hi Andrew, > -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Saturday, June 10, 2017 5:36 PM > To: Mintz, Yuval > Cc: Salil Mehta; davem@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; > lipeng (Y); mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next 8/9] net: hns3: Add support of debugfs > interface to HNS3 driver > > On Sat, Jun 10, 2017 at 12:51:57PM +0000, Mintz, Yuval wrote: > > > This adds the support of the debugfs interface to the driver for > debugging > > > purposes. > > > > > +const struct hclge_support_cmd support_cmd[] = { > > > + {"send cmd", 8, hclge_dbg_send, > > > + "opcode flag data0 data1 data2 data3 data4 data5"}, > > > + {"help", 4, hclge_dbg_usage, "no option"}, }; > > > > Is there an actual description of what this does? Or is it simply a > huge backdoor? > > It looks like a huge backdoor to the chip. > > It is O.K. to have such a patch internally for your own development > work, but it should not be submitted for mainline. > > NACK > > Andrew I will drop this debugfs patch for now. Thanks Salil