DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E6A28804EB
Subject: Re: [PATCH 3/3] livepatch: add shadow variable sample program
To: Miroslav Benes <mbenes@suse.cz>
References: <1496341526-19061-1-git-send-email-joe.lawrence@redhat.com>
 <1496341526-19061-4-git-send-email-joe.lawrence@redhat.com>
 <alpine.LSU.2.20.1706131256540.29266@pobox.suse.cz>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        Josh Poimboeuf <jpoimboe@redhat.com>, Jessica Yu <jeyu@redhat.com>,
        Jiri Kosina <jikos@kernel.org>, Petr Mladek <pmladek@suse.com>
From: Joe Lawrence <joe.lawrence@redhat.com>
Organization: Red Hat
Message-ID: <e6287260-736d-f91e-9516-c6a485f77c17@redhat.com>
Date: Tue, 13 Jun 2017 13:32:05 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <alpine.LSU.2.20.1706131256540.29266@pobox.suse.cz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 844
Lines: 30

On 06/13/2017 07:00 AM, Miroslav Benes wrote:
> On Thu, 1 Jun 2017, Joe Lawrence wrote:
> 
>> Modify the sample livepatch to demonstrate the shadow variable API.
>>
>> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
>> ---
>>  samples/livepatch/livepatch-sample.c | 39 +++++++++++++++++++++++++++++++++++-
>>  1 file changed, 38 insertions(+), 1 deletion(-)
> 
> Would it make sense to make this our second sample module? I think we 
> should keep one as simple as possible, and illustrate new features in 
> separate sample modules.
> 
> I'd like to have another one for klp-convert patch set too.
> 
> What do you think?
> 
> Miroslav
> 

Yeah, adding this as a new sample module is a good idea.  I'll split
that out in v2.

I'm not familiar with klp-convert, so I'll assume that will be handled
as its own patch(set).

Thanks,

-- Joe