Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753933AbdFMSA7 (ORCPT ); Tue, 13 Jun 2017 14:00:59 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46382 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753804AbdFMSAg (ORCPT ); Tue, 13 Jun 2017 14:00:36 -0400 Date: Tue, 13 Jun 2017 14:00:34 -0400 (EDT) Message-Id: <20170613.140034.1178710287073869026.davem@davemloft.net> To: jon.mason@broadcom.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, robh+dt@kernel.org, frowand.list@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, liviu@dudau.co.uk, mpe@ellerman.id.au Subject: Re: [PATCH net-next] of_mdio: move of_mdio_parse_addr to header file From: David Miller In-Reply-To: <1497365768-17627-1-git-send-email-jon.mason@broadcom.com> References: <1497365768-17627-1-git-send-email-jon.mason@broadcom.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 13 Jun 2017 10:18:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 600 Lines: 14 From: Jon Mason Date: Tue, 13 Jun 2017 10:56:08 -0400 > The of_mdio_parse_addr() helper function is useful to other code, but > the module dependency chain causes issues. To work around this, we can > move of_mdio_parse_addr() to be an inline function in the header file. > This gets rid of the dependencies and still allows for the reuse of > code. > > Reported-by: Liviu Dudau > Signed-off-by: Jon Mason > Fixes: 342fa1964439 ("mdio: mux: make child bus walking more permissive and errors more verbose") Applied, thank you.