Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753270AbdFMSD0 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Jun 2017 14:03:26 -0400
Received: from mga09.intel.com ([134.134.136.24]:63490 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751802AbdFMSDY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Jun 2017 14:03:24 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,338,1493708400"; 
   d="scan'208";a="112720864"
Date: Tue, 13 Jun 2017 21:03:19 +0300
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: tmp: fix potential null pointer dereference
Message-ID: <20170613180319.ezszgevmgwno2v5u@intel.com>
References: <20170530215123.GA7484@embeddedgus>
 <20170531121129.f3576lq7peott6gd@intel.com>
 <20170612172544.Horde.Br2grYSXmXw3bfXZefqg8tb@gator4166.hostgator.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170612172544.Horde.Br2grYSXmXw3bfXZefqg8tb@gator4166.hostgator.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: NeoMutt/20170306 (1.8.0)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1360
Lines: 45

On Mon, Jun 12, 2017 at 05:25:44PM -0500, Gustavo A. R. Silva wrote:
> Hi Jarkko,
> 
> Please, see my comments below
> 
> Quoting Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>:
> 
> > On Tue, May 30, 2017 at 04:51:23PM -0500, Gustavo A. R. Silva wrote:
> > > NULL check at line 147: if (chip) {, implies chip might be NULL.
> > > Function dev_get_drvdata() dereference pointer chip.
> > > Move pointer priv assignment inside the IF block that checks
> > > pointer chip.
> > > 
> > > Addresses-Coverity-ID: 1397646
> > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> > 
> > It cannot be.
> > 
> 
> I got it.
> 
> > /Jarkko
> > 
> > > ---
> > >  drivers/char/tpm/tpm_atmel.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c
> > > index 0d322ab..0826efd 100644
> > > --- a/drivers/char/tpm/tpm_atmel.c
> > > +++ b/drivers/char/tpm/tpm_atmel.c
> > > @@ -142,9 +142,10 @@ static struct platform_device *pdev;
> > >  static void atml_plat_remove(void)
> > >  {
> > >  	struct tpm_chip *chip = dev_get_drvdata(&pdev->dev);
> > > -	struct tpm_atmel_priv *priv = dev_get_drvdata(&chip->dev);
> > > +	struct tpm_atmel_priv *priv;
> > > 
> > >  	if (chip) {
> 
> So, this NULL check could be removed?

Yes, this would be right way to fix it.

/Jarkko