Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753969AbdFMUQg (ORCPT ); Tue, 13 Jun 2017 16:16:36 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:39329 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbdFMUQb (ORCPT ); Tue, 13 Jun 2017 16:16:31 -0400 Subject: Re: [PATCH] dt-bindings: Drop k2g genpd device ID macros To: Santosh Shilimkar References: <20170522183737.24946-1-d-gerlach@ti.com> <20170531162850.mf6giowmxj5vetxq@rob-hp-laptop> CC: Rob Herring , , , , , Nishanth Menon , Keerthy , Arnd Bergmann , Tero Kristo , Ulf Hansson , Kevin Hilman , Suman Anna , Andrew Davis , Franklin Cooper From: Dave Gerlach Message-ID: Date: Tue, 13 Jun 2017 15:16:01 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170531162850.mf6giowmxj5vetxq@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.203] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 29 Santosh, On 05/31/2017 11:28 AM, Rob Herring wrote: > On Mon, May 22, 2017 at 01:37:37PM -0500, Dave Gerlach wrote: >> Commit 7cc119f29b19 ("dt-bindings: Add TI SCI PM Domains") introduced a >> number of K2G_DEV_x macros to represent each device ID available on the >> K2G platform for use by the genpd, clock, and reset drivers. Rather than >> use these macros, which are only used in the device tree for property >> values and not actually used by the drivers, let's just use the device >> ID number directly in the device tree to avoid macro bloat. >> >> Signed-off-by: Dave Gerlach >> --- >> Based on discussion here [1] it was agreed that these macros are not needed >> and it is better to just use the device IDs directly in dt. >> >> [1] https://www.spinics.net/lists/arm-kernel/msg577079.html >> >> .../devicetree/bindings/soc/ti/sci-pm-domain.txt | 5 +- >> include/dt-bindings/genpd/k2g.h | 90 ---------------------- >> 2 files changed, 3 insertions(+), 92 deletions(-) >> delete mode 100644 include/dt-bindings/genpd/k2g.h > > Acked-by: Rob Herring > Gentle ping on this. If you're OK with the patch any chance you can pick it up? Regards, Dave