Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753845AbdFMUrr (ORCPT ); Tue, 13 Jun 2017 16:47:47 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35982 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbdFMUrq (ORCPT ); Tue, 13 Jun 2017 16:47:46 -0400 Date: Tue, 13 Jun 2017 21:46:53 +0100 From: Mark Brown To: Sugar Zhang Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org, Liam Girdwood , Rob Herring , Mark Rutland , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20170613204653.f6yfph5ixp4s42fh@sirena.org.uk> References: <1496998369-30556-1-git-send-email-sugar.zhang@rock-chips.com> <1496998369-30556-3-git-send-email-sugar.zhang@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="32scs6rvuyf6zx23" Content-Disposition: inline In-Reply-To: <1496998369-30556-3-git-send-email-sugar.zhang@rock-chips.com> X-Cookie: Life is the urge to ecstasy. User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v1 2/4] ASoC: rockchip: i2s: add support for i2s bclk fs configuration X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 30 --32scs6rvuyf6zx23 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 09, 2017 at 04:52:47PM +0800, Sugar Zhang wrote: > +- rockchip,bclk-fs: configure the i2s bclk fs. Rather than having a driver DT property for this the device should implement a set_bclk_ratio() operation and let the ratio be set by the machine driver. The simple and graph cards may need extending for that, I know they have MCLK configuration support already. --32scs6rvuyf6zx23 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAllATz0ACgkQJNaLcl1U h9CUsAgAgYKjrOEF+7y92AmwJKw0AVK6H0gjUt5P8GtC6Pawr49GcPcRlGGoHG63 UVCt1tcli8Uh1V0aQMpEZG2eWUyGw5E0KWn4l/C8Xx2xiByNzJrovnDWq2stUDik MyTVh29b3zE/Wu8KdH/mqi1I1liNmsv/w5MgStyX2FVwD1xJlvJq9uufDlNb7AVz mEXQtIP+/lQm8Fo1EIrxA2jL8wgAb9oALd6KmGeXahyk+HB02i4DV8mCpyENK8gP i5Dieqm+Pi3ciC55I7ylERTAOV4ADvOpPMq+AeOxi9OS1exXibG4DAif3SQg+B2J asA9eg7k+8IUpjdxNd4rv/qiyBxeUw== =QUUW -----END PGP SIGNATURE----- --32scs6rvuyf6zx23--