Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753703AbdFMVdU (ORCPT ); Tue, 13 Jun 2017 17:33:20 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:51726 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbdFMVdT (ORCPT ); Tue, 13 Jun 2017 17:33:19 -0400 Date: Tue, 13 Jun 2017 17:33:18 -0400 (EDT) Message-Id: <20170613.173318.167061176274123943.davem@davemloft.net> To: magnus.damm@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] via-rhine: add support for changing MTU From: David Miller In-Reply-To: <149737430797.28477.9215445312169809396.sendpatchset@little-apple> References: <149737430797.28477.9215445312169809396.sendpatchset@little-apple> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 13 Jun 2017 13:51:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 20 From: Magnus Damm Date: Wed, 14 Jun 2017 02:18:27 +0900 > From: Magnus Damm > > Allow adjusting the MTU for via-rhine devices in case of no TX alignment > buffer is used. > > Lightly tested on ALIX2D13 hardware by making use of VXLAN with MTU set > to 1500 on top of via-rhine devices with 1550 MTU. Without this patch > the VXLAN MTU is limited to less than 1500. > > Signed-off-by: Magnus Damm Why is the TX alignment buffer such an obstacle? It would be so much nicer if this could be supported for all chip variants instead of some certain subset which users have no idea of figuring out. It's a really bad user experience to set them up for failure like this.