Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753906AbdFMVpO (ORCPT ); Tue, 13 Jun 2017 17:45:14 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:36796 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbdFMVpM (ORCPT ); Tue, 13 Jun 2017 17:45:12 -0400 MIME-Version: 1.0 In-Reply-To: <20170613144749.yn6z7yecumrfaayk@mwanda> References: <1497042442-3620-1-git-send-email-srishtishar@gmail.com> <20170613130006.GA15978@kroah.com> <20170613144749.yn6z7yecumrfaayk@mwanda> From: srishti sharma Date: Wed, 14 Jun 2017 03:15:11 +0530 Message-ID: Subject: Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis. To: Dan Carpenter Cc: Greg KH , stefan.wahren@i2se.com, devel@driverdev.osuosl.org, Florian Fainelli , sbranden@broadcom.com, rjui@broadcom.com, linux-kernel@vger.kernel.org, Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2200 Lines: 61 On Tue, Jun 13, 2017 at 8:17 PM, Dan Carpenter wrote: > On Tue, Jun 13, 2017 at 08:07:14PM +0530, srishti sharma wrote: >> On Tue, Jun 13, 2017 at 6:30 PM, Greg KH wrote: >> > On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote: >> >> Fixed alignment so that it matched open parenthesis. >> >> >> >> Signed-off-by: srishti sharma >> >> --- >> >> drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c >> >> index f484bb0..2148ed0 100644 >> >> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c >> >> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c >> >> @@ -105,7 +105,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol, >> >> } >> >> >> >> static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol, >> >> - struct snd_ctl_elem_value *ucontrol) >> >> + struct snd_ctl_elem_value *ucontrol) >> >> { >> >> struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol); >> >> int changed = 0; >> > >> > This patch is corrupted and can not be applied :( >> >> >> Why is this corrupted ? > > Try applying it with `git am`. There should be space characters at the > start of these lines but your email client deleted them: > > struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol); > int changed = 0; > > Read Documentation/process/email-clients.rst > > regards, > dan carpenter Hello, I tried applying it with ' git am ' and it was giving me this error: fatal: corrupt patch at line XX I think this was produced because of running ./scripts/cleanfile on the patch . I was using this to fix trailing whitespaces . So, I used a different method to remove them and didn't get that error. But now when I run 'git am' I get a different error: error: patch failed: drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c:105 Why am I getting this error ? Regards, Srishti