Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008AbdFMXzZ (ORCPT ); Tue, 13 Jun 2017 19:55:25 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:33096 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525AbdFMXzW (ORCPT ); Tue, 13 Jun 2017 19:55:22 -0400 Date: Tue, 13 Jun 2017 16:55:14 -0700 From: Stephen Hemminger To: Salil Mehta Cc: , , , , , , , Subject: Re: [PATCH V2 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver Message-ID: <20170613165514.757eb40f@xeon-e3> In-Reply-To: <20170613231035.494020-8-salil.mehta@huawei.com> References: <20170613231035.494020-1-salil.mehta@huawei.com> <20170613231035.494020-8-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1736 Lines: 42 On Wed, 14 Jun 2017 00:10:34 +0100 Salil Mehta wrote: > +/* netdev related stats */ > +#define HNS3_NETDEV_STAT(_string, _member) \ > + { _string, \ > + FIELD_SIZEOF(struct rtnl_link_stats64, _member), \ > + offsetof(struct rtnl_link_stats64, _member), \ > + } > + > +static const struct hns3_stats hns3_netdev_stats[] = { > + /* misc. Rx/Tx statistics */ > + HNS3_NETDEV_STAT("rx_packets", rx_packets), > + HNS3_NETDEV_STAT("tx_packets", tx_packets), > + HNS3_NETDEV_STAT("rx_bytes", rx_bytes), > + HNS3_NETDEV_STAT("tx_bytes", tx_bytes), > + HNS3_NETDEV_STAT("rx_errors", rx_errors), > + HNS3_NETDEV_STAT("tx_errors", tx_errors), > + HNS3_NETDEV_STAT("rx_dropped", rx_dropped), > + HNS3_NETDEV_STAT("tx_dropped", tx_dropped), > + HNS3_NETDEV_STAT("multicast", multicast), > + HNS3_NETDEV_STAT("collisions", collisions), > + > + /* detailed Rx errors */ > + HNS3_NETDEV_STAT("rx_length_errors", rx_length_errors), > + HNS3_NETDEV_STAT("rx_over_errors", rx_over_errors), > + HNS3_NETDEV_STAT("rx_crc_errors", rx_crc_errors), > + HNS3_NETDEV_STAT("rx_frame_errors", rx_frame_errors), > + HNS3_NETDEV_STAT("rx_fifo_errors", rx_fifo_errors), > + HNS3_NETDEV_STAT("rx_missed_errors", rx_missed_errors), > + > + /* detailed Tx errors */ > + HNS3_NETDEV_STAT("tx_aborted_errors", tx_aborted_errors), > + HNS3_NETDEV_STAT("tx_carrier_errors", tx_carrier_errors), > + HNS3_NETDEV_STAT("tx_fifo_errors", tx_fifo_errors), > + HNS3_NETDEV_STAT("tx_heartbeat_errors", tx_heartbeat_errors), > + HNS3_NETDEV_STAT("tx_window_errors", tx_window_errors), > + Ethtool statistics should be reserved for device specific values and should not be used just to clone statistics that already exist in the network device.