Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753995AbdFNAyl (ORCPT ); Tue, 13 Jun 2017 20:54:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:33348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbdFNAyk (ORCPT ); Tue, 13 Jun 2017 20:54:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C33822CB7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sstabellini@kernel.org Date: Tue, 13 Jun 2017 17:54:38 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-X260 To: Juergen Gross cc: Stefano Stabellini , xen-devel@lists.xen.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, Stefano Stabellini Subject: Re: [PATCH v3 14/18] xen/pvcalls: disconnect and module_exit In-Reply-To: <62e395b4-b4af-34d8-134a-222984ebe779@suse.com> Message-ID: References: <1496431915-20774-1-git-send-email-sstabellini@kernel.org> <1496431915-20774-14-git-send-email-sstabellini@kernel.org> <62e395b4-b4af-34d8-134a-222984ebe779@suse.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2930 Lines: 116 On Tue, 13 Jun 2017, Juergen Gross wrote: > On 02/06/17 21:31, Stefano Stabellini wrote: > > Implement backend_disconnect. Call pvcalls_back_release_active on active > > sockets and pvcalls_back_release_passive on passive sockets. > > > > Implement module_exit by calling backend_disconnect on frontend > > connections. > > > > Signed-off-by: Stefano Stabellini > > CC: boris.ostrovsky@oracle.com > > CC: jgross@suse.com > > --- > > drivers/xen/pvcalls-back.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > > > diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c > > index b541887..6afe7a0 100644 > > --- a/drivers/xen/pvcalls-back.c > > +++ b/drivers/xen/pvcalls-back.c > > @@ -800,6 +800,38 @@ static int backend_connect(struct xenbus_device *dev) > > > > static int backend_disconnect(struct xenbus_device *dev) > > { > > + struct pvcalls_fedata *priv; > > + struct sock_mapping *map, *n; > > + struct sockpass_mapping *mappass; > > + struct radix_tree_iter iter; > > + void **slot; > > + > > + > > + priv = dev_get_drvdata(&dev->dev); > > + > > + list_for_each_entry_safe(map, n, &priv->socket_mappings, list) { > > + pvcalls_back_release_active(dev, priv, map); > > + } > > You can drop the {} OK > > + > > + radix_tree_for_each_slot(slot, &priv->socketpass_mappings, &iter, 0) { > > + mappass = radix_tree_deref_slot(slot); > > + if (!mappass || radix_tree_exception(mappass)) { > > This looks fishy. > > You might call radix_tree_deref_retry(NULL). Right now this is okay, > but you depend on the radix tree internals here. I'll avoid id > > + if (radix_tree_deref_retry(mappass)) { > > + slot = radix_tree_iter_retry(&iter); > > + continue; > > The continue; statement is pointless here. I'll remove it > > + } > > + } else > > + pvcalls_back_release_passive(dev, priv, mappass); > > + } > > + > > + xenbus_unmap_ring_vfree(dev, (void *)priv->sring); > > Drop the cast. OK > > + unbind_from_irqhandler(priv->irq, dev); > > + > > + list_del(&priv->list); > > + destroy_workqueue(priv->wq); > > + kfree(priv); > > + dev_set_drvdata(&dev->dev, NULL); > > + > > return 0; > > } > > > > @@ -993,3 +1025,20 @@ static int __init pvcalls_back_init(void) > > return 0; > > } > > module_init(pvcalls_back_init); > > + > > +static void __exit pvcalls_back_fin(void) > > +{ > > + struct pvcalls_fedata *priv, *npriv; > > + > > + down(&pvcalls_back_global.frontends_lock); > > + list_for_each_entry_safe(priv, npriv, &pvcalls_back_global.frontends, > > + list) { > > + backend_disconnect(priv->dev); > > + } > > + up(&pvcalls_back_global.frontends_lock); > > + > > + xenbus_unregister_driver(&pvcalls_back_driver); > > + memset(&pvcalls_back_global, 0, sizeof(pvcalls_back_global)); > > Why? legacy code, I'll remove it > Juergen > > > +} > > + > > +module_exit(pvcalls_back_fin); > > >