Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754230AbdFNFJy (ORCPT ); Wed, 14 Jun 2017 01:09:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42302 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754072AbdFNFJx (ORCPT ); Wed, 14 Jun 2017 01:09:53 -0400 Date: Wed, 14 Jun 2017 07:09:43 +0200 From: Greg KH To: srishti sharma Cc: Dan Carpenter , stefan.wahren@i2se.com, devel@driverdev.osuosl.org, Florian Fainelli , sbranden@broadcom.com, linux-kernel@vger.kernel.org, Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, rjui@broadcom.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis. Message-ID: <20170614050943.GC11953@kroah.com> References: <1497042442-3620-1-git-send-email-srishtishar@gmail.com> <20170613130006.GA15978@kroah.com> <20170613144749.yn6z7yecumrfaayk@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2226 Lines: 60 On Wed, Jun 14, 2017 at 03:15:11AM +0530, srishti sharma wrote: > On Tue, Jun 13, 2017 at 8:17 PM, Dan Carpenter wrote: > > On Tue, Jun 13, 2017 at 08:07:14PM +0530, srishti sharma wrote: > >> On Tue, Jun 13, 2017 at 6:30 PM, Greg KH wrote: > >> > On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote: > >> >> Fixed alignment so that it matched open parenthesis. > >> >> > >> >> Signed-off-by: srishti sharma > >> >> --- > >> >> drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- > >> >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> >> > >> >> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > >> >> index f484bb0..2148ed0 100644 > >> >> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > >> >> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > >> >> @@ -105,7 +105,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol, > >> >> } > >> >> > >> >> static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol, > >> >> - struct snd_ctl_elem_value *ucontrol) > >> >> + struct snd_ctl_elem_value *ucontrol) > >> >> { > >> >> struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol); > >> >> int changed = 0; > >> > > >> > This patch is corrupted and can not be applied :( > >> > >> > >> Why is this corrupted ? > > > > Try applying it with `git am`. There should be space characters at the > > start of these lines but your email client deleted them: > > > > struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol); > > int changed = 0; > > > > Read Documentation/process/email-clients.rst > > > > regards, > > dan carpenter > > > Hello, > > I tried applying it with ' git am ' and it was giving me this error: > > fatal: corrupt patch at line XX Exactly. > I think this was produced because of running ./scripts/cleanfile on the patch . Why would you do that? By doing that you corrupted the patch file :( Just use the proper output of 'git format-patch' and all will be fine. thanks, greg k-h