From: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
To: Ian Arkver <ian.arkver.dev@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
        "mattw@codeaurora.org" <mattw@codeaurora.org>,
        "mitchelh@codeaurora.org" <mitchelh@codeaurora.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>
CC: "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        Chris Paterson <Chris.Paterson2@renesas.com>
Subject: RE: [PATCH v2 0/2] Avoid namespace collision within macros & tidyup
Thread-Topic: [PATCH v2 0/2] Avoid namespace collision within macros & tidyup
Thread-Index: AQHS5EuQch6xHlSbTUW6E1FNMAjbuKIj68wAgAAGKIA=
Date: Wed, 14 Jun 2017 07:18:09 +0000
Message-ID: <KL1PR0601MB20388B133E5E841FF5BF2D4BC3C30@KL1PR0601MB2038.apcprd06.prod.outlook.com>
References: <20170613133348.48044-1-ramesh.shanmugasundaram@bp.renesas.com>
 <293256b4-2477-e5f6-eca6-e5eaf9b14876@gmail.com>
In-Reply-To: <293256b4-2477-e5f6-eca6-e5eaf9b14876@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2017 07:18:09.5799
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0702
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5E7IUFk013173
Content-Length: 1760
Lines: 53

> Subject: Re: [PATCH v2 0/2] Avoid namespace collision within macros &
> tidyup
> 
> On 13/06/17 14:33, Ramesh Shanmugasundaram wrote:
> > Hi All,
> >
> > The readx_poll_timeout & similar macros defines local variable that
> > can cause name space collision with the caller. Fixed this issue by
> > prefixing them with underscores.
> 
> The compound statement has a local variable scope, so these won't collide
> with the caller I believe.

But xxx_poll_timeout is a macro??

Usage regmap_read_poll_timeout(..., timeout) with variable name "timeout" in the caller results in 

include/linux/regmap.h:123:20: warning: 'timeout' is used uninitialized in this function [-Wuninitialized]
  ktime_t timeout = ktime_add_us(ktime_get(), timeout_us); \

> 
> > Also tidied couple of instances where the macro arguments are used in
> > expressions without paranthesis.
> >
> > This patchset is based on top of today's linux-next repo.
> > commit bc4c75f41a1c ("Add linux-next specific files for 20170613")
> >
> > Change history:
> >
> > v2:
> >   - iopoll.h:
> > 	- Enclosed timeout_us & sleep_us arguments with paranthesis
> >   - regmap.h:
> > 	- Enclosed timeout_us & sleep_us arguments with paranthesis
> > 	- Renamed pollret to __ret
> >
> > Note: timeout_us cause spare check warning as identified here [1].
> >
> > [1]
> > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg1513
> > 8.html
> >
> > Thanks,
> > Ramesh
> >
> > Ramesh Shanmugasundaram (2):
> >    iopoll: Avoid namespace collision within macros & tidyup
> >    regmap: Avoid namespace collision within macro & tidyup
> >
> >   include/linux/iopoll.h | 12 +++++++-----
> >   include/linux/regmap.h | 17 +++++++++--------
> >   2 files changed, 16 insertions(+), 13 deletions(-)
> >