From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
To: Salil Mehta <salil.mehta@huawei.com>,
        "davem@davemloft.net" <davem@davemloft.net>
CC: "Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
        huangdaode <huangdaode@hisilicon.com>,
        "lipeng (Y)" <lipeng321@huawei.com>,
        "mehta.salil.lnk@gmail.com" <mehta.salil.lnk@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linuxarm <linuxarm@huawei.com>
Subject: RE: [PATCH net-next 1/9] net: hns3: Add support of HNS3 Ethernet
 Driver for hip08 SoC
Thread-Topic: [PATCH net-next 1/9] net: hns3: Add support of HNS3 Ethernet
 Driver for hip08 SoC
Thread-Index: AQHS4ZylAUR/9UEISEenwnHcN46eG6IeAvvAgAUJGQCAAPlbEA==
Date: Wed, 14 Jun 2017 08:04:17 +0000
Message-ID: <BLUPR0701MB2004897373CA744917699BCA8DC30@BLUPR0701MB2004.namprd07.prod.outlook.com>
References: <20170610034630.493852-1-salil.mehta@huawei.com>
 <20170610034630.493852-2-salil.mehta@huawei.com>
 <BY2PR0701MB2005075560E4EA9F455049988DCF0@BY2PR0701MB2005.namprd07.prod.outlook.com>
 <F4CC6FACFEB3C54C9141D49AD221F7F93B7A1B62@FRAEML521-MBX.china.huawei.com>
In-Reply-To: <F4CC6FACFEB3C54C9141D49AD221F7F93B7A1B62@FRAEML521-MBX.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2017 08:04:17.8946
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB2004
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5E84VKB021240
Content-Length: 1617
Lines: 50

> > > +static void hns3_nic_net_down(struct net_device *ndev) {
> > > +	struct hns3_nic_priv *priv = netdev_priv(ndev);
> > > +	struct hnae3_ae_ops *ops;
> > > +	int i;
> > > +
> > > +	netif_tx_stop_all_queues(ndev);
> > > +	netif_carrier_off(ndev);
> > > +	netif_tx_disable(ndev);
> > > +
> > > +	ops = priv->ae_handle->ae_algo->ops;
> > > +
> > > +	if (ops->stop)
> > > +		ops->stop(priv->ae_handle);
> > > +
> > > +	netif_tx_stop_all_queues(ndev);
> >
> > Looks a bit excessive. Why do you need all these
> > netif_tx_stop_all_queues()?
> If we are disabling the netdev. We need to stop scheduling the queues
> associated with that netdev for TX, so we need this code. Why do you think
> it is excessive?

Why do you need both netif_tx_disable() and netif_tx_stop_all_queues()?
And why would you need to re-do netif_tx_stop_all_queues() after
calling ops->stop()?

> > Isn't mqprio going to override your priority2tc mapping with the one
> > provided by user?
> I guess you are referring to below code in the mqprio_init() - right?
> 
> static int mqprio_init(struct Qdisc *sch, struct nlattr *opt)
> {
>   [...]
> 	/* Always use supplied priority mappings */
> 	for (i = 0; i < TC_BITMASK + 1; i++)
> 		netdev_set_prio_tc_map(dev, i, qopt->prio_tc_map[i]);
>   [...]
> }
> 
> In this case yes, you are right below code seems to be redundant:
> 
>  +	/* Assign UP2TC map for the VSI */
>  +	for (i = 0; i < HNAE3_MAX_TC; i++) {
>  +		netdev_set_prio_tc_map(ndev,
>  +				       kinfo->tc_info[i].up,
>  +				       kinfo->tc_info[i].tc);
> 
> Hope I am not missing anything here?
You're not; That's what I meant.