Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbdFNJLP (ORCPT ); Wed, 14 Jun 2017 05:11:15 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:36758 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbdFNJK1 (ORCPT ); Wed, 14 Jun 2017 05:10:27 -0400 MIME-Version: 1.0 In-Reply-To: <20170614084253.GZ3187@lahna.fi.intel.com> References: <20170614074720.GA29175@elgon.mountain> <20170614084253.GZ3187@lahna.fi.intel.com> From: Andreas Noever Date: Wed, 14 Jun 2017 11:10:05 +0200 Message-ID: Subject: Re: [PATCH] thunderbolt: Fix reset response_type To: Mika Westerberg , Dan Carpenter , Greg KH Cc: Michael Jamet , Yehezkel Bernat , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 624 Lines: 14 On Wed, Jun 14, 2017 at 10:42 AM, Mika Westerberg wrote: > On Wed, Jun 14, 2017 at 10:47:21AM +0300, Dan Carpenter wrote: >> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET) >> instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the >> same as TB_CFG_PKG_NOTIFY_ACK. >> >> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable") >> Signed-off-by: Dan Carpenter > > Good catch! > > Acked-by: Mika Westerberg Signed-off-by: Andreas Noever