Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbdFNJkn (ORCPT ); Wed, 14 Jun 2017 05:40:43 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:34005 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbdFNJjx (ORCPT ); Wed, 14 Jun 2017 05:39:53 -0400 Subject: Re: [PATCH] tee: add forward declaration for struct device To: Jens Wiklander , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tee-dev@lists.linaro.org, Arnd Bergmann References: <6344683a299d05692ed64ddb963343ea9547add4.1496229347.git.jerome.forissier@linaro.org> From: Jerome Forissier Message-ID: <2bcbf7b0-7dba-7e72-72fd-4da922e442bb@linaro.org> Date: Wed, 14 Jun 2017 11:39:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <6344683a299d05692ed64ddb963343ea9547add4.1496229347.git.jerome.forissier@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 32 [+Arnd] Ping? Thanks, -- Jerome On 05/31/2017 01:21 PM, Jerome Forissier wrote: > tee_drv.h references struct device, but does not include device.h nor > platform_device.h. Therefore, if tee_drv.h is included by some file > that does not pull device.h nor platform_device.h beforehand, we have a > compile warning. Fix this by adding a forward declaration. > > Signed-off-by: Jerome Forissier > --- > include/linux/tee_drv.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h > index 8614713..07bd226 100644 > --- a/include/linux/tee_drv.h > +++ b/include/linux/tee_drv.h > @@ -29,6 +29,7 @@ > #define TEE_SHM_DMA_BUF BIT(1) /* Memory with dma-buf handle */ > #define TEE_SHM_EXT_DMA_BUF BIT(2) /* Memory with dma-buf handle */ > > +struct device; > struct tee_device; > struct tee_shm; > struct tee_shm_pool; >