Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752214AbdFNJn7 (ORCPT ); Wed, 14 Jun 2017 05:43:59 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:36307 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbdFNJn5 (ORCPT ); Wed, 14 Jun 2017 05:43:57 -0400 MIME-Version: 1.0 In-Reply-To: <20170613202517.26558-1-alexandre.belloni@free-electrons.com> References: <20170613202517.26558-1-alexandre.belloni@free-electrons.com> From: Andy Shevchenko Date: Wed, 14 Jun 2017 12:43:40 +0300 Message-ID: Subject: Re: [PATCH] tty/serial: remove AVR32 specific access wrappers To: Alexandre Belloni Cc: Richard Genoud , Greg Kroah-Hartman , Nicolas Ferre , "linux-serial@vger.kernel.org" , linux-arm Mailing List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1729 Lines: 59 On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni wrote: > Now that AVR32 is gone, the specific wrappers for that architecture are > unnecessary and will not be compiled anymore. > Can you rebase this on top of tty-next? I'm pretty sure this patch will gone. > Signed-off-by: Alexandre Belloni > --- > drivers/tty/serial/atmel_serial.c | 17 ----------------- > 1 file changed, 17 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 937d67f22fba..8bfc566df2da 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -228,21 +228,6 @@ static inline void atmel_uart_writel(struct uart_port *port, u32 reg, u32 value) > __raw_writel(value, port->membase + reg); > } > > -#ifdef CONFIG_AVR32 > - > -/* AVR32 cannot handle 8 or 16bit I/O accesses but only 32bit I/O accesses */ > -static inline u8 atmel_uart_read_char(struct uart_port *port) > -{ > - return __raw_readl(port->membase + ATMEL_US_RHR); > -} > - > -static inline void atmel_uart_write_char(struct uart_port *port, u8 value) > -{ > - __raw_writel(value, port->membase + ATMEL_US_THR); > -} > - > -#else > - > static inline u8 atmel_uart_read_char(struct uart_port *port) > { > return __raw_readb(port->membase + ATMEL_US_RHR); > @@ -253,8 +238,6 @@ static inline void atmel_uart_write_char(struct uart_port *port, u8 value) > __raw_writeb(value, port->membase + ATMEL_US_THR); > } > > -#endif > - > #ifdef CONFIG_SERIAL_ATMEL_PDC > static bool atmel_use_pdc_rx(struct uart_port *port) > { > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko