Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752180AbdFNJqh (ORCPT ); Wed, 14 Jun 2017 05:46:37 -0400 Received: from mga06.intel.com ([134.134.136.31]:18477 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbdFNJqN (ORCPT ); Wed, 14 Jun 2017 05:46:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,340,1493708400"; d="scan'208";a="1141152378" Date: Wed, 14 Jun 2017 11:46:09 +0200 From: Jarkko Sakkinen To: "Gustavo A. R. Silva" Cc: Peter Huewe , Marcel Selhorst , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] char: tpm: remove unnecessary NULL check Message-ID: <20170614094609.yop3p25riqzop6ft@intel.com> References: <20170613180319.ezszgevmgwno2v5u@intel.com> <20170613195542.GA5677@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170613195542.GA5677@embeddedgus> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1378 Lines: 43 On Tue, Jun 13, 2017 at 02:55:42PM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary NULL check. > Pointer _chip_ cannot be NULL in this instance. > > Addresses-Coverity-ID: 1397646 > Cc: Jarkko Sakkinen > Signed-off-by: Gustavo A. R. Silva > --- > drivers/char/tpm/tpm_atmel.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c > index 0d322ab..66a1452 100644 > --- a/drivers/char/tpm/tpm_atmel.c > +++ b/drivers/char/tpm/tpm_atmel.c > @@ -144,13 +144,11 @@ static void atml_plat_remove(void) > struct tpm_chip *chip = dev_get_drvdata(&pdev->dev); > struct tpm_atmel_priv *priv = dev_get_drvdata(&chip->dev); > > - if (chip) { > - tpm_chip_unregister(chip); > - if (priv->have_region) > - atmel_release_region(priv->base, priv->region_size); > - atmel_put_base_addr(priv->iobase); > - platform_device_unregister(pdev); > - } > + tpm_chip_unregister(chip); > + if (priv->have_region) > + atmel_release_region(priv->base, priv->region_size); > + atmel_put_base_addr(priv->iobase); > + platform_device_unregister(pdev); > } > > static SIMPLE_DEV_PM_OPS(tpm_atml_pm, tpm_pm_suspend, tpm_pm_resume); > -- > 2.5.0 > Thank you. Reviewed-by: Jarkko Sakkinen /Jarkko