Message-ID: <1497436908.18751.43.camel@perches.com>
Subject: Re: [PATCH] checkpatch: HLIST_HEAD is also declaration
From: Joe Perches <joe@perches.com>
To: Steffen Maier <maier@linux.vnet.ibm.com>,
        Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Cc: linux-s390@vger.kernel.org
Date: Wed, 14 Jun 2017 03:41:48 -0700
In-Reply-To: <20170614101626.81494-1-maier@linux.vnet.ibm.com>
References: <20170614101626.81494-1-maier@linux.vnet.ibm.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 991
Lines: 31

On Wed, 2017-06-14 at 12:16 +0200, Steffen Maier wrote:
> Fixes the following false warning:
> 
>     WARNING: Missing a blank line after declarations
>     #71: FILE: drivers/s390/scsi/zfcp_fsf.c:422:
>     +	struct hlist_node *tmp;
>     +	HLIST_HEAD(remove_queue);
> 
> Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>

OK, thanks but what about PLIST_HEAD, LLIST_

What

> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index baa3c7be04ad..a539fb2561bc 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -714,7 +714,7 @@ our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)};
>  
>  our $declaration_macros = qr{(?x:
>  	(?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
> -	(?:$Storage\s+)?LIST_HEAD\s*\(|
> +	(?:$Storage\s+)?H?LIST_HEAD\s*\(|
>  	(?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
>  )};
>