Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbdFNLGM (ORCPT ); Wed, 14 Jun 2017 07:06:12 -0400 Received: from mail-wr0-f173.google.com ([209.85.128.173]:36699 "EHLO mail-wr0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbdFNLGL (ORCPT ); Wed, 14 Jun 2017 07:06:11 -0400 Subject: Re: [PATCH] tee: add forward declaration for struct device To: Arnd Bergmann , Jens Wiklander Cc: Linux Kernel Mailing List , Linux ARM , tee-dev@lists.linaro.org References: <6344683a299d05692ed64ddb963343ea9547add4.1496229347.git.jerome.forissier@linaro.org> <2bcbf7b0-7dba-7e72-72fd-4da922e442bb@linaro.org> <20170614094610.GA12598@jax> From: Jerome Forissier Message-ID: <8f026b3a-9b5f-f819-817e-db812a02c129@linaro.org> Date: Wed, 14 Jun 2017 13:06:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1971 Lines: 65 On 06/14/2017 01:01 PM, Arnd Bergmann wrote: > On Wed, Jun 14, 2017 at 11:46 AM, Jens Wiklander > wrote: >> On Wed, Jun 14, 2017 at 11:39:50AM +0200, Jerome Forissier wrote: >>> [+Arnd] >>> >>> Ping? >>> >>> Thanks, >>> -- >>> Jerome >>> >>> On 05/31/2017 01:21 PM, Jerome Forissier wrote: >>>> tee_drv.h references struct device, but does not include device.h nor >>>> platform_device.h. Therefore, if tee_drv.h is included by some file >>>> that does not pull device.h nor platform_device.h beforehand, we have a >>>> compile warning. Fix this by adding a forward declaration. >>>> >>>> Signed-off-by: Jerome Forissier > > Acked-by: Arnd Bergmann > > Do we need this to fix a warning in mainline, in linux-next, or only > in combination with some other patches? Only with some other patches. -- Jerome > I have not run into this warning in my build testing. > >>>> include/linux/tee_drv.h | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h >>>> index 8614713..07bd226 100644 >>>> --- a/include/linux/tee_drv.h >>>> +++ b/include/linux/tee_drv.h >>>> @@ -29,6 +29,7 @@ >>>> #define TEE_SHM_DMA_BUF BIT(1) /* Memory with dma-buf handle */ >>>> #define TEE_SHM_EXT_DMA_BUF BIT(2) /* Memory with dma-buf handle */ >>>> >>>> +struct device; >>>> struct tee_device; >>>> struct tee_shm; >>>> struct tee_shm_pool; >>>> >> >> Looks good to me. >> >> Reviewed-by: Jens Wiklander > > Can you pick up the patch in your git tree and send a pull request for > the appropriate release (4.12-fixes or 4.13)? > > If you don't expect to send anything else for tee in that release, > you can also forward the patch to arm@kernel.org and ask for > inclusion. If you just reply with the 'Reviewed-by', I would not > expect to have to do anything in the arm-soc tree. > > Arnd >