Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbdFNL7p (ORCPT ); Wed, 14 Jun 2017 07:59:45 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:33053 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbdFNL7o (ORCPT ); Wed, 14 Jun 2017 07:59:44 -0400 MIME-Version: 1.0 In-Reply-To: <8f026b3a-9b5f-f819-817e-db812a02c129@linaro.org> References: <6344683a299d05692ed64ddb963343ea9547add4.1496229347.git.jerome.forissier@linaro.org> <2bcbf7b0-7dba-7e72-72fd-4da922e442bb@linaro.org> <20170614094610.GA12598@jax> <8f026b3a-9b5f-f819-817e-db812a02c129@linaro.org> From: Arnd Bergmann Date: Wed, 14 Jun 2017 13:59:43 +0200 X-Google-Sender-Auth: ZIeKRZ0mrgoCVE9vHzejkLJKbcU Message-ID: Subject: Re: [PATCH] tee: add forward declaration for struct device To: Jerome Forissier Cc: Jens Wiklander , Linux Kernel Mailing List , Linux ARM , tee-dev@lists.linaro.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1187 Lines: 36 On Wed, Jun 14, 2017 at 1:06 PM, Jerome Forissier wrote: > On 06/14/2017 01:01 PM, Arnd Bergmann wrote: >> On Wed, Jun 14, 2017 at 11:46 AM, Jens Wiklander >> wrote: >>> On Wed, Jun 14, 2017 at 11:39:50AM +0200, Jerome Forissier wrote: >>>> [+Arnd] >>>> >>>> Ping? >>>> >>>> Thanks, >>>> -- >>>> Jerome >>>> >>>> On 05/31/2017 01:21 PM, Jerome Forissier wrote: >>>>> tee_drv.h references struct device, but does not include device.h nor >>>>> platform_device.h. Therefore, if tee_drv.h is included by some file >>>>> that does not pull device.h nor platform_device.h beforehand, we have a >>>>> compile warning. Fix this by adding a forward declaration. >>>>> >>>>> Signed-off-by: Jerome Forissier >> >> Acked-by: Arnd Bergmann >> >> Do we need this to fix a warning in mainline, in linux-next, or only >> in combination with some other patches? > > Only with some other patches. Ok, in that case, Jens can just queue up the patch in his tree now, and it will be there in time when other patches get applied on top, no need to have this in arm-soc by itself. Thanks, Arnd