Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379AbdFNMe3 (ORCPT ); Wed, 14 Jun 2017 08:34:29 -0400 Received: from foss.arm.com ([217.140.101.70]:32916 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbdFNMe2 (ORCPT ); Wed, 14 Jun 2017 08:34:28 -0400 Date: Wed, 14 Jun 2017 13:34:19 +0100 From: Catalin Marinas To: Olav Haugan Cc: will.deacon@arm.com, robin.murphy@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64/dma-mapping: Remove extraneous null-pointer checks Message-ID: <20170614123418.GB44176@MBP.local> References: <20170613205614.15872-1-ohaugan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170613205614.15872-1-ohaugan@codeaurora.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 586 Lines: 20 On Tue, Jun 13, 2017 at 01:56:14PM -0700, Olav Haugan wrote: > The current null-pointer check in __dma_alloc_coherent and > __dma_free_coherent is not needed anymore since the > __dma_alloc/__dma_free functions won't be called if !dev (dummy ops will > be called instead). > > Signed-off-by: Olav Haugan > --- > arch/arm64/include/asm/dma-mapping.h | 2 -- > arch/arm64/mm/dma-mapping.c | 9 --------- > 2 files changed, 11 deletions(-) Thanks. Reviewed-by: Catalin Marinas Will should pick this up for 4.13 -- Catalin