Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbdFNMnR (ORCPT ); Wed, 14 Jun 2017 08:43:17 -0400 Received: from mailbackend.panix.com ([166.84.1.89]:43880 "EHLO mailbackend.panix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbdFNMnP (ORCPT ); Wed, 14 Jun 2017 08:43:15 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170601210045.8638-1-zackw@panix.com> <20170602071014.GA16118@infradead.org> <3c311c8b-e8a3-0cbe-1c7e-b336c4c0f894@panix.com> From: Zack Weinberg Date: Wed, 14 Jun 2017 08:43:08 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] uapi/linux/a.out.h: don't use deprecated system-specific predefines. To: Linus Torvalds Cc: Christoph Hellwig , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 838 Lines: 22 On Fri, Jun 2, 2017 at 3:12 PM, Linus Torvalds wrote: > On Fri, Jun 2, 2017 at 5:06 AM, Zack Weinberg wrote: >> On 06/02/2017 03:10 AM, Christoph Hellwig wrote: >>> >>> Can we please fix these conditionals so that only those >>> relevant to Linux remain? >> >> I was going for the minimal change since this is dusty-deck code that I >> can't practically test, but I have no objection to your more thorough >> approach. I don't see anything I would do differently. > > Yes, I think I'd just prefer to rip out the stale stuff, and remove > the "#ifdef linux" entirely. > > It's not like the kernel wants non-linux headers, and I don't see > non-linux users using the kernel headers either. Christoph's patch doesn't seem to have been applied yet. Is there anything I can do to help? zw