Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752585AbdFNNJa (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Jun 2017 09:09:30 -0400
Received: from szxga03-in.huawei.com ([45.249.212.189]:7419 "EHLO
        szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752389AbdFNNJ2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Jun 2017 09:09:28 -0400
Subject: Re: [PATCH v2 1/2] libsas: Don't process sas events in static works
To: wangyijing <wangyijing@huawei.com>,
        Johannes Thumshirn <jthumshirn@suse.de>, <jejb@linux.vnet.ibm.com>,
        <martin.petersen@oracle.com>
References: <1497425597-18799-1-git-send-email-wangyijing@huawei.com>
 <1497425597-18799-2-git-send-email-wangyijing@huawei.com>
 <692abe7a-149f-c1bf-5f28-3e36cad81b5a@suse.de> <5940FC1C.5050000@huawei.com>
CC: <chenqilin2@huawei.com>, <hare@suse.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <chenxiang66@hisilicon.com>,
        <huangdaode@hisilicon.com>, <wangkefeng.wang@huawei.com>,
        <zhaohongjiang@huawei.com>, <dingtianhong@huawei.com>,
        <guohanjun@huawei.com>, <yanaijie@huawei.com>, <hch@lst.de>,
        <dan.j.williams@intel.com>, <emilne@redhat.com>, <thenzl@redhat.com>,
        <wefu@redhat.com>, <charles.chenxin@huawei.com>,
        <chenweilong@huawei.com>, Yousong He <heyousong@huawei.com>
From: John Garry <john.garry@huawei.com>
Message-ID: <00f4b3f1-ada0-d07d-2640-d902a437b24e@huawei.com>
Date: Wed, 14 Jun 2017 14:08:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <5940FC1C.5050000@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.203.181.153]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A020206.59413556.02E5,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 31a0f252690a3b0b907398366bee93ab
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1163
Lines: 30

On 14/06/2017 10:04, wangyijing wrote:
>>>  static void notify_ha_event(struct sas_ha_struct *sas_ha, enum ha_event event)
>>> >>  {
>>> >> +	struct sas_ha_event *ev;
>>> >> +
>>> >>  	BUG_ON(event >= HA_NUM_EVENTS);
>>> >>
>>> >> -	sas_queue_event(event, &sas_ha->pending,
>>> >> -			&sas_ha->ha_events[event].work, sas_ha);
>>> >> +	ev = kzalloc(sizeof(*ev), GFP_ATOMIC);
>>> >> +	if (!ev)
>>> >> +		return;
>> > GFP_ATOMIC allocations can fail and then no events will be queued *and* we
>> > don't report the error back to the caller.
>> >
> Yes, it's really a problem, but I don't find a better solution, do you have some suggestion ?
>

Dan raised an issue with this approach, regarding a malfunctioning PHY 
which spews out events. I still don't think we're handling it safely. 
Here's the suggestion:
- each asd_sas_phy owns a finite-sized pool of events
- when the event pool becomes exhausted, libsas stops queuing events 
(obviously) and disables the PHY in the LLDD
- upon attempting to re-enable the PHY from sysfs, libsas first checks 
that the pool is still not exhausted

If you cannot find a good solution, then let us know and we can help.

John