Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbdFNNJy (ORCPT ); Wed, 14 Jun 2017 09:09:54 -0400 Received: from mail-ve1eur01on0049.outbound.protection.outlook.com ([104.47.1.49]:58880 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751806AbdFNNJx (ORCPT ); Wed, 14 Jun 2017 09:09:53 -0400 From: Ruxandra Ioana Radulescu To: Greg KH CC: "devel@driverdev.osuosl.org" , "stuyoder@gmail.com" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "agraf@suse.de" , Bharat Bhushan , Bogdan Purcareata , "linux-arm-kernel@lists.infradead.org" , Laurentiu Tudor Subject: RE: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields Thread-Topic: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields Thread-Index: AQHS3tWv+Qg1zsy7F0OzKHoYJi6An6IimxMAgAHFyuA= Date: Wed, 14 Jun 2017 13:09:47 +0000 Message-ID: References: <20170606150041.10955-1-ruxandra.radulescu@nxp.com> <20170606150041.10955-16-ruxandra.radulescu@nxp.com> <20170613100358.GA11444@kroah.com> In-Reply-To: <20170613100358.GA11444@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.146.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR0401MB1852;7:36Mtl3BJCf7yyVtarT5SIFIvWXKy8ajxXqTP85lObWB1Lig4t14YeGApYCzhu7n8AHHiYQZXAwxBUKsB0WNOYOjefy+epvWXPynKskV3rie8Xgcrek5WhGG/4KxWYW/EU6ccT3GZTs1H14gE4FZBLH4UydAXtC5HQSCuUv+sgBbxiHryYtz7EZyNJiyWmIuVLRUH85NSxNSU9IfIReFwKV0Iklwkxo3EXyNVpfGHHG6Uwljdk367c0WToJ/Wxt9FyXM+JGNuBrR5nP92EHMiFDI9WIFPpBMwyiVw/iRffBe8MhOJD4T1iUF3mISvL+gr5NuzcWuZQLLibppqDw0Vsg== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39450400003)(39840400002)(39850400002)(39400400002)(39860400002)(24454002)(13464003)(377454003)(50986999)(5660300001)(2906002)(39060400002)(54356999)(76176999)(7736002)(53936002)(7696004)(6246003)(74316002)(25786009)(53546009)(86362001)(6506006)(6436002)(2900100001)(14454004)(55016002)(8936002)(99286003)(4326008)(3280700002)(9686003)(3660700001)(66066001)(54906002)(81166006)(478600001)(8676002)(33656002)(189998001)(6116002)(102836003)(3846002)(5250100002)(229853002)(2950100002)(6916009)(110136004)(38730400002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0401MB1852;H:VI1PR0402MB2847.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-office365-filtering-correlation-id: ba277402-63f5-436b-45e1-08d4b326a263 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:HE1PR0401MB1852; x-ms-traffictypediagnostic: HE1PR0401MB1852: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR0401MB1852;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR0401MB1852; x-forefront-prvs: 033857D0BD spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2017 13:09:47.9064 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB1852 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5ED9xl9004403 Content-Length: 1270 Lines: 35 > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Tuesday, June 13, 2017 1:04 PM > To: Ruxandra Ioana Radulescu > Cc: devel@driverdev.osuosl.org; stuyoder@gmail.com; arnd@arndb.de; > linux-kernel@vger.kernel.org; agraf@suse.de; Bharat Bhushan > ; Bogdan Purcareata > ; linux-arm-kernel@lists.infradead.org; > Laurentiu Tudor > Subject: Re: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields > > On Tue, Jun 06, 2017 at 10:00:38AM -0500, Ioana Radulescu wrote: > > Reorder fields in the device's private structure such that > > the ones most used on the hotpath are at the beginning of > > the structure. > > > > This brings a small performance improvement due to better > > cache usage. > > Really? What kind of performance improvement? Always be specific. Fair point, thanks. The test scenario was ipfwd with small frames and the improvement ~1%, but I took this patch from an internal repo, so I need to redo the measurements on the current tree before resending. > > Please fix up and resend. We're preparing a larger patchset with several optimizations, I'll probably include the v2 there. Thanks, Ioana