Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752476AbdFNNfc (ORCPT ); Wed, 14 Jun 2017 09:35:32 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54929 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbdFNNfb (ORCPT ); Wed, 14 Jun 2017 09:35:31 -0400 From: Steffen Maier To: Andy Whitcroft , Joe Perches , linux-kernel@vger.kernel.org Cc: linux-s390@vger.kernel.org, Steffen Maier Subject: [PATCH v2] checkpatch: [HLP]LIST_HEAD is also declaration Date: Wed, 14 Jun 2017 15:35:12 +0200 X-Mailer: git-send-email 2.11.2 In-Reply-To: <1497437132.18751.45.camel@perches.com> References: <1497437132.18751.45.camel@perches.com> X-TM-AS-GCONF: 00 x-cbid: 17061413-0008-0000-0000-0000046718FC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17061413-0009-0000-0000-00001DF038FA Message-Id: <20170614133512.89425-1-maier@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-14_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706140228 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 32 Fixes the following false warning among others for LLIST_HEAD and PLIST_HEAD: WARNING: Missing a blank line after declarations #71: FILE: drivers/s390/scsi/zfcp_fsf.c:422: + struct hlist_node *tmp; + HLIST_HEAD(remove_queue); Signed-off-by: Steffen Maier --- Changes from v1: Extended it to also support LLIST_HEAD and PLIST_HEAD as suggested by Joe Perches. scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4b9569fa931b..86818b0ba8be 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -732,7 +732,7 @@ our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)}; our $declaration_macros = qr{(?x: (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(| - (?:$Storage\s+)?LIST_HEAD\s*\(| + (?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(| (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\( )}; -- 2.11.2