Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751937AbdFNNvs (ORCPT ); Wed, 14 Jun 2017 09:51:48 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:43084 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbdFNNvr (ORCPT ); Wed, 14 Jun 2017 09:51:47 -0400 Subject: Re: [PATCH v3 14/18] xen/pvcalls: disconnect and module_exit To: Stefano Stabellini , Juergen Gross References: <1496431915-20774-1-git-send-email-sstabellini@kernel.org> <1496431915-20774-14-git-send-email-sstabellini@kernel.org> <62e395b4-b4af-34d8-134a-222984ebe779@suse.com> Cc: xen-devel@lists.xen.org, linux-kernel@vger.kernel.org, Stefano Stabellini From: Boris Ostrovsky Message-ID: Date: Wed, 14 Jun 2017 09:51:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 382 Lines: 16 >>> static int backend_disconnect(struct xenbus_device *dev) >>> { >>> + struct pvcalls_fedata *priv; >>> + struct sock_mapping *map, *n; >>> + struct sockpass_mapping *mappass; >>> + struct radix_tree_iter iter; >>> + void **slot; >>> + >>> + >>> + priv = dev_get_drvdata(&dev->dev); Can you also rename priv to something else (like fedata)? And in other routines too. -boris