Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752031AbdFNO3m (ORCPT ); Wed, 14 Jun 2017 10:29:42 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:60052 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751707AbdFNO3l (ORCPT ); Wed, 14 Jun 2017 10:29:41 -0400 Date: Wed, 14 Jun 2017 10:29:40 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Arvind Yadav cc: gregkh@linuxfoundation.org, , Subject: Re: [PATCH] usb: host: ohci-pxa27x: Handle return value of clk_prepare_enable In-Reply-To: <9adc506aa3b14033472a7a473d842962d155e005.1497419972.git.arvind.yadav.cs@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 46 On Wed, 14 Jun 2017, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/host/ohci-pxa27x.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c > index 79efde8f..c5afdb2 100644 > --- a/drivers/usb/host/ohci-pxa27x.c > +++ b/drivers/usb/host/ohci-pxa27x.c > @@ -281,7 +281,9 @@ static int pxa27x_start_hc(struct pxa27x_ohci *pxa_ohci, struct device *dev) > > inf = dev_get_platdata(dev); > > - clk_prepare_enable(pxa_ohci->clk); > + retval = clk_prepare_enable(pxa_ohci->clk); > + if (retval) > + return retval; You might as well remove the initializer for retval ("int retval = 0;") because the initial value will always be overwritten here. > > pxa27x_reset_hc(pxa_ohci); > > @@ -296,8 +298,10 @@ static int pxa27x_start_hc(struct pxa27x_ohci *pxa_ohci, struct device *dev) > if (inf->init) > retval = inf->init(dev); > > - if (retval < 0) > + if (retval < 0) { > + clk_disable_unprepare(pxa_ohci->clk); > return retval; > + } > > if (cpu_is_pxa3xx()) > pxa3xx_u2d_start_hc(&hcd->self); Aside from that one issue, Acked-by: Alan Stern Alan Stern