Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752254AbdFNOrI (ORCPT ); Wed, 14 Jun 2017 10:47:08 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:36541 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbdFNOrG (ORCPT ); Wed, 14 Jun 2017 10:47:06 -0400 MIME-Version: 1.0 In-Reply-To: <20170407131649.GH16503@dragon> References: <1491501735-1649-1-git-send-email-jagan@openedev.com> <1491501735-1649-2-git-send-email-jagan@openedev.com> <20170407131649.GH16503@dragon> From: Jagan Teki Date: Wed, 14 Jun 2017 20:17:04 +0530 Message-ID: Subject: Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node To: Shawn Guo Cc: Jagan Teki , linux-arm-kernel , devicetree , linux-kernel , Sascha Hauer , Fabio Estevam , Matteo Lisi , Michael Trimarchi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 37 On Fri, Apr 7, 2017 at 6:46 PM, Shawn Guo wrote: > On Thu, Apr 06, 2017 at 11:32:07PM +0530, Jagan Teki wrote: >> From: Jagan Teki >> >> Add support for Sound card and related codec(via i2c1) nodes >> on Engicam Is.IoT MX6UL variant module boards. >> >> Cc: Shawn Guo >> Cc: Matteo Lisi >> Cc: Michael Trimarchi >> Signed-off-by: Jagan Teki >> --- >> Changes for v3: >> - Replace fsl,imx-audio-sgtl5000 and use simple-audio-card >> Changes for v2: >> - Use proper [label:] node-name[@unit-address] for codec >> - Remove incorrect codec property 'wlf,shared-lrclk' >> - Remove 'gpr' from sound card node >> >> arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 10 +++++++ >> arch/arm/boot/dts/imx6ul-isiot.dtsi | 44 ++++++++++++++++++++++++++++++ > > Can you help me understand how these two files are related? Why is > sgtl5000 added into one and sound node added into the other? lcdif, ts and sound card which may differ based on the base-board connected with SOM, So I moved these stuff which are related to Starter kit supported once's and used with SOM dts files. if some other board with same SOM can have different lcdif and etc so they can define locally to dts. thanks! -- Jagan Teki Senior Linux Kernel Engineer | Amarula Solutions U-Boot, Linux | Upstream Maintainer Hyderabad, India.