Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752459AbdFNOs5 (ORCPT ); Wed, 14 Jun 2017 10:48:57 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:16165 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752427AbdFNOsx (ORCPT ); Wed, 14 Jun 2017 10:48:53 -0400 X-AuditID: b6c32a2d-f792a6d0000055a1-5a-59414cd37b78 From: Bartlomiej Zolnierkiewicz To: Arvind Yadav Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: pxafb: Handle return value of clk_prepare_enable Date: Wed, 14 Jun 2017 16:48:47 +0200 Message-id: <3453913.nT1TzBXoXS@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <5e0ce70b74924acc351ce4d8ef846c28f8e6ceda.1496829008.git.arvind.yadav.cs@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsWy7bCmuu5lH8dIgzurWSyu9S5ktjjR94HV 4vKuOWwOzB47Z91l9/i8SS6AKYrLJiU1J7MstUjfLoEr42fXU5aCs0wVz+5sZWtgnMDUxcjJ ISFgIrHj1ztWCFtM4sK99WxdjFwcQgJLGSV2zpjBCuF8ZpTYMv0BG0zH9gvn2SESOxglrh68 xQzhfGWUWNq/HWwWm4CVxMT2VYwgtoiAjsSmmb/BbGYBW4nXp8+A2cICYRLXZu0Hu4NFQFVi 79w2sA28ApoSR99+A6sRFfCS2LKvHayGUyBJYkrvXSaIGkGJH5PvsUDMlJfYt38qK4StI3H2 2DpGkIMkBO6zSRw7thKoiAPIkZXYdIAZ4gMXiVV7lzNC2MISr45vYYewpSS6O2ZB2dMZJbb/ loCYs5lRYtXuCVAJa4nDxy9CLeOT6P39hAliPq9ER5sQRImHxL8VW6HWOkp8bfGEhA/QmCl3 vrFOYJSfheSFWUhemIXkhQWMzKsYxVILinPTU4tNC4z0ihNzi0vz0vWS83M3MYLTgZbuDsYv C7wPMQpwMCrx8K4wdYwUYk0sK67MPcQowcGsJML72g0oxJuSWFmVWpQfX1Sak1p8iFGag0VJ nFd95bUIIYH0xJLU7NTUgtQimCwTB6dUA2NVw47vtetadvUJVgdkTTMwPXjuoPKOuKfMsw6c /mOu8dRE5dB9G8ETid3Xf174LZf05sCFUB67eY9jr3Dt6Tj94C9P/0c9xomGV3Z63GlTtNxw TtwRGBTH6jvC3vtzfZBcu2oty4uvHesb7xZoOi7Zt2eBy4L1h04vjQ1ynHTE465k4DOJw7JK LMUZiYZazEXFiQC0RFJxAwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42I5/e+xgO4lH8dIg/2v5C2u9S5ktjjR94HV 4vKuOWwOzB47Z91l9/i8SS6AKcrNJiM1MSW1SCE1Lzk/JTMv3VYpNMRN10JJIS8xN9VWKULX NyRISaEsMacUyDMyQAMOzgHuwUr6dgluGT+7nrIUnGWqeHZnK1sD4wSmLkZODgkBE4ntF86z Q9hiEhfurWfrYuTiEBLYxiix4s9OZgjnK6PEhntX2ECq2ASsJCa2r2IEsUUEdCQ2zfwNZjML 2Eq8Pn0GzBYWCJO4Nms/2AYWAVWJvXPbwHp5BTQljr79BlYjKuAlsWVfO1gNp0CSxLttNxgh lm1llLiwfR87RIOgxI/J91ggFshL7Ns/lRXC1pJYv/M40wRGgVlIymYhKZuFpGwBI/MqRq7U guLc9NxiowKjTYzAKNh2WCtgB2PTuehDjAIcjEo8vAwWjpFCrIllxZW5hxglOJiVRHhfuwGF eFMSK6tSi/Lji0pzUosPMZoC/TSRWUo0OR8YoXkl8YYmlkYmBmZmhkYGxmZK4rwTAr9ECAmk J5akZqemFqQWwfQxcXBKNTCu9eNcunijcrz116Nq5wut/IrqhCbJfRYJOd96yIh/du62qex1 0mIZLJf2mqR8NTa7eu7sr8t3YiZGBzgVFPn1LApeoOGyVOhMPuv/JdufSVbt1uI9a3L2or+V rF6Vy7uPnruqBL+Laa35xnuwqdp5xeF7+VvF1Wo3seieWz/58sboObFyNwKVWIozEg21mIuK EwFSjBcZmAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170614144850epcas5p2ec9d5b66a87cb190d17fa18aa292b6ac X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-CMS-RootMailID: 20170607095229epcas3p1730b65f2db44accc1f7b950d2265bb19 X-RootMTR: 20170607095229epcas3p1730b65f2db44accc1f7b950d2265bb19 References: <5e0ce70b74924acc351ce4d8ef846c28f8e6ceda.1496829008.git.arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 319 Lines: 12 On Wednesday, June 07, 2017 03:22:09 PM Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav Patch queued for 4.13, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics