Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbdFNPAM (ORCPT ); Wed, 14 Jun 2017 11:00:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:48592 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751857AbdFNPAK (ORCPT ); Wed, 14 Jun 2017 11:00:10 -0400 Subject: Re: [PATCH v3 2/4] xen: add sysfs node for guest type To: Boris Ostrovsky , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Cc: gregkh@linuxfoundation.org References: <20170612142150.15283-1-jgross@suse.com> <20170612142150.15283-3-jgross@suse.com> <89f9f367-3c8d-adf9-1a8e-9ad87da95ea7@oracle.com> From: Juergen Gross Message-ID: Date: Wed, 14 Jun 2017 17:00:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <89f9f367-3c8d-adf9-1a8e-9ad87da95ea7@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 23 On 14/06/17 16:48, Boris Ostrovsky wrote: > >> diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c >> index 84106f9c456c..d641e9970d5d 100644 >> --- a/drivers/xen/sys-hypervisor.c >> +++ b/drivers/xen/sys-hypervisor.c >> @@ -50,6 +50,18 @@ static int __init xen_sysfs_type_init(void) >> return sysfs_create_file(hypervisor_kobj, &type_attr.attr); >> } >> >> +static ssize_t guest_type_show(struct hyp_sysfs_attr *attr, char *buffer) >> +{ >> + return sprintf(buffer, "%s\n", xen_guest_type); >> +} > > > So I know I gave my R-b for this patch but can't we just key off > xen_domain_type and not have xen_guest_type at all? So we'd need to introduce XEN_PVH_DOMAIN and adjust xen_hvm_domain(). Juergen