Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbdFNTLc (ORCPT ); Wed, 14 Jun 2017 15:11:32 -0400 Received: from mail-ot0-f181.google.com ([74.125.82.181]:35730 "EHLO mail-ot0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbdFNTLa (ORCPT ); Wed, 14 Jun 2017 15:11:30 -0400 MIME-Version: 1.0 In-Reply-To: <1923573.HjpiSnITgW@en-pc05> References: <1472121518-9340-1-git-send-email-stefan.schoefegger@ginzinger.com> <2668097.SlerkO2uVy@en-pc05> <20170613135847.GA7128@bhelgaas-glaptop.roam.corp.google.com> <1923573.HjpiSnITgW@en-pc05> From: Fabio Estevam Date: Wed, 14 Jun 2017 16:11:29 -0300 Message-ID: Subject: Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option To: =?UTF-8?Q?Sch=C3=B6fegger_Stefan?= Cc: Bjorn Helgaas , "linux-pci@vger.kernel.org" , Richard Zhu , Arnd Bergmann , open list , Kishon Vijay Abraham I , Jingoo Han , Bjorn Helgaas , "moderated list:PCI DRIVER FOR IMX6" , Lucas Stach Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5EJBnP6029392 Content-Length: 782 Lines: 18 On Wed, Jun 14, 2017 at 2:52 AM, Schöfegger Stefan wrote: > device). The bitrate and de-emphasis must be switched. The driver (without > this patches) does not allow to switch to gen2 because it falls back to gen1. > It is impossible to generate the gen2 test pattern. If you pass 'fsl,max-link-speed = <2>;' in your device tree, then it will allow gen2. >From Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt: "- fsl,max-link-speed: Specify PCI gen for link capability. Must be '2' for gen2, otherwise will default to gen1. Note that the IMX6 LVDS clock outputs do not meet gen2 jitter requirements and thus for gen2 capability a gen2 compliant clock generator should be used and configured." Wouldn't this solve the problem?