Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbdFNTPg (ORCPT ); Wed, 14 Jun 2017 15:15:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:37046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621AbdFNTPe (ORCPT ); Wed, 14 Jun 2017 15:15:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7C52214E1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sstabellini@kernel.org Date: Wed, 14 Jun 2017 12:15:32 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-X260 To: Boris Ostrovsky cc: Stefano Stabellini , Juergen Gross , xen-devel@lists.xen.org, linux-kernel@vger.kernel.org, Stefano Stabellini Subject: Re: [PATCH v3 14/18] xen/pvcalls: disconnect and module_exit In-Reply-To: Message-ID: References: <1496431915-20774-1-git-send-email-sstabellini@kernel.org> <1496431915-20774-14-git-send-email-sstabellini@kernel.org> <62e395b4-b4af-34d8-134a-222984ebe779@suse.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 454 Lines: 16 On Wed, 14 Jun 2017, Boris Ostrovsky wrote: > >>> static int backend_disconnect(struct xenbus_device *dev) > >>> { > >>> + struct pvcalls_fedata *priv; > >>> + struct sock_mapping *map, *n; > >>> + struct sockpass_mapping *mappass; > >>> + struct radix_tree_iter iter; > >>> + void **slot; > >>> + > >>> + > >>> + priv = dev_get_drvdata(&dev->dev); > > Can you also rename priv to something else (like fedata)? And in other > routines too. Yes, done