Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752167AbdFNUGO (ORCPT ); Wed, 14 Jun 2017 16:06:14 -0400 Received: from mail-qt0-f173.google.com ([209.85.216.173]:35725 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbdFNUGK (ORCPT ); Wed, 14 Jun 2017 16:06:10 -0400 Date: Wed, 14 Jun 2017 16:06:08 -0400 From: Andy Gross To: Sricharan R Cc: Varadarajan Narayanan , broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, david.brown@linaro.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Subject: Re: [PATCH 10/18] spi: qup: Fix DMA mode interrupt handling Message-ID: <20170614200608.GE32733@hector.wework.com> References: <1497419551-21834-1-git-send-email-varada@codeaurora.org> <1497419551-21834-11-git-send-email-varada@codeaurora.org> <66ba7dfb-6ff3-884e-6db0-8d5191f87c93@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66ba7dfb-6ff3-884e-6db0-8d5191f87c93@codeaurora.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2226 Lines: 56 On Wed, Jun 14, 2017 at 12:51:11PM +0530, Sricharan R wrote: > Hi Varada, > > On 6/14/2017 11:22 AM, Varadarajan Narayanan wrote: > > This is needed for v1, where the i/o completion is not > > handled in the dma driver. > > > > Signed-off-by: Andy Gross > > Signed-off-by: Varadarajan Narayanan > > --- > > drivers/spi/spi-qup.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c > > index 872de28..bd53e82 100644 > > --- a/drivers/spi/spi-qup.c > > +++ b/drivers/spi/spi-qup.c > > @@ -510,9 +510,9 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) > > > > writel_relaxed(qup_err, controller->base + QUP_ERROR_FLAGS); > > writel_relaxed(spi_err, controller->base + SPI_ERROR_FLAGS); > > - writel_relaxed(opflags, controller->base + QUP_OPERATIONAL); > > > > if (!xfer) { > > + writel_relaxed(opflags, controller->base + QUP_OPERATIONAL); > > This does look correct to remove acknowledging the QUP in normal case and > do it conditionally only when xfer = NULL. This is to probably mask the issue of getting erroneous/spurious IRQs. > > > dev_err_ratelimited(controller->dev, "unexpected irq %08x %08x %08x\n", > > qup_err, spi_err, opflags); > > return IRQ_HANDLED; > > @@ -540,7 +540,15 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) > > error = -EIO; > > } > > > > - if (!spi_qup_is_dma_xfer(controller->mode)) { > > + if (spi_qup_is_dma_xfer(controller->mode)) { > > + writel_relaxed(opflags, controller->base + QUP_OPERATIONAL); > > + if (opflags & QUP_OP_IN_SERVICE_FLAG && > > + opflags & QUP_OP_MAX_INPUT_DONE_FLAG) > > + complete(&controller->rxc); > > + if (opflags & QUP_OP_OUT_SERVICE_FLAG && > > + opflags & QUP_OP_MAX_OUTPUT_DONE_FLAG) > > + complete(&controller->txc); > > + } else { > > Is this because in patch #8 that we do not populate the dma callback > for v1. If that is done, this should not be required at all, as the > complete would be signalled from the dma callback. I believe that is true. There shouldn't be any IRQs for DMA enabled transactions (at least BAM-dma).