Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752419AbdFNVIU (ORCPT ); Wed, 14 Jun 2017 17:08:20 -0400 Received: from prod-mx.aristanetworks.com ([162.210.130.12]:60927 "EHLO prod-mx.aristanetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbdFNVIT (ORCPT ); Wed, 14 Jun 2017 17:08:19 -0400 From: Julien Gomes Subject: Re: [PATCH net-next 2/3] ipmr: add netlink notifications on igmpmsg cache reports To: nicolas.dichtel@6wind.com, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, nikolay@cumulusnetworks.com References: <20170613170822.16310-1-julien@arista.com> <20170613170822.16310-3-julien@arista.com> Message-ID: <3390ae4f-53ab-2ec3-5e5c-20b3fc05de4f@arista.com> Date: Wed, 14 Jun 2017 14:08:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1644 Lines: 45 On 06/14/2017 12:56 AM, Nicolas Dichtel wrote: > Le 13/06/2017 à 19:08, Julien Gomes a écrit : >> Add Netlink notifications on cache reports in ipmr, in addition to the >> existing igmpmsg sent to mroute_sk. >> Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE. >> >> MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >> same data as their equivalent fields in the igmpmsg header. >> PKT attribute is the packet sent to mroute_sk, without the added igmpmsg >> header. >> >> Suggested-by: Ryan Halbrook >> Signed-off-by: Julien Gomes >> --- >> include/uapi/linux/mroute.h | 11 ++++++++ >> net/ipv4/ipmr.c | 63 +++++++++++++++++++++++++++++++++++++++++++-- >> 2 files changed, 72 insertions(+), 2 deletions(-) >> >> diff --git a/include/uapi/linux/mroute.h b/include/uapi/linux/mroute.h >> index f904367c0cee..f6f9e01ee734 100644 >> --- a/include/uapi/linux/mroute.h >> +++ b/include/uapi/linux/mroute.h >> @@ -152,6 +152,17 @@ enum { >> }; >> #define IPMRA_VIFA_MAX (__IPMRA_VIFA_MAX - 1) >> >> +/* ipmr netlink cache report attributes */ >> +enum { > IPMRA_CACHEREPORTA_UNSPEC is missing. Indeed, I will add it. > By the way, maybe something shorter than IPMRA_CACHEREPORTA_ would be better. > What about IPMR_CREPORTA_? IPMR_CACHEA_? IPMR_IGMPA_? or whatever. I see absolutely no issue in shortening them. IPMRA_CREPORT_ sounds good to me. > What is the signification of the two 'A'? One for 'attribute', but the other? Now that you mention it, the second 'A' is simply redundant. I will remove it and go with IPMRA_CREPORT_. -- Julien Gomes