Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbdFNVR3 (ORCPT ); Wed, 14 Jun 2017 17:17:29 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:50386 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098AbdFNVR1 (ORCPT ); Wed, 14 Jun 2017 17:17:27 -0400 From: Arnd Bergmann To: Andrew Morton Cc: kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Andrey Ryabinin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arend van Spriel , Arnd Bergmann Subject: [PATCH v2 01/11] compiler: introduce noinline_if_stackbloat annotation Date: Wed, 14 Jun 2017 23:15:36 +0200 Message-Id: <20170614211556.2062728-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170614211556.2062728-1-arnd@arndb.de> References: <20170614211556.2062728-1-arnd@arndb.de> X-Provags-ID: V03:K0:+tGQB6NdWJwGazOfEPEbnzEBysfXUiv3tsiUtkOrgh4wYL0j6tz VXfj77Q+NIQsx5lKmOFRxkg55grWJwVcOSgghlH5yZDoK8alDvHBCEeIha7iQxsMcOKYQHy Hff7KX73co/5PvwQ3TNr+l/jcQ9eAvR3MsmqAP0CmZLxkVd+MpR7istWgxluhpQcbbO36s9 8u0yjMZkCXBWVKELY3w1A== X-UI-Out-Filterresults: notjunk:1;V01:K0:pV5ohuZLQ88=:wHsGVCorTo1zc/648OWXVC 2nUvrt9H8kVN9UX2JvaICE2mu6zg8l6GGyDRfGUtLWrRrGnvFO1yJQmsTXI3YZFLxMsEwnm8I /JEIl5Yc31TeKqxYRldoc1jbyUd/eWqctWfpukiUVProrghpb0FzHcPd7fdo2+uAfUH6+xoBr 2ijKJ+OLSmhjGEQBHnWlwsnPRaL4HWVzJVfHi7QyGdtu1NPIQy2jgkda6KPtnxPzJxmYFxGFf DJBYZvIV3PDf69hHyZqT4n0PZTmudx9eJkzUQZYTmASUclkoHlPRUZg59+78MrDXOl/24/34J hD29fHGSyJPQ7NrTWDFqizN2kftHYMdWFBej3SedUeBQZp5E34d+Fr0TFllEUvt+hwSod8dXI ToIDdoY3/YtuzrBerXFaCPIihnKb0VMKmZ2CGPyfCBaWqEmtnGLToSem3KTOWli55FKpXIFLK kFKnQ01Jjks7CWKlh798M0UuePe87hsIG+Bf3K2ZCAGwUvMQjnPVezaDgg91Y8y07Cx44hB+s zN+YrCrPtw+I+XIQD6/yNygFA0h3QOI1d/MVjhpRiaojlhlufYLZn7IpxFMZMcx4VtK9ORDVg pASEcokPnzwTJPh7bqywQWDqPKhjhUMZrAZJgpwLLGA0fBYvv4n794gMFN8PTDkyN5Uxhb8K2 H+O6TrfvMv8B0KWIub0Cn7m8iWvgqYWUsa5XYIFMQzTF8A9AqPOEbe80eh7ISvvavSMk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1555 Lines: 40 When CONFIG_KASAN is set, we can run into some code that uses incredible amounts of kernel stack: drivers/staging/dgnc/dgnc_neo.c:1056:1: error: the frame size of 11112 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/media/i2c/cx25840/cx25840-core.c:4960:1: error: the frame size of 94000 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/media/dvb-frontends/stv090x.c:3430:1: error: the frame size of 5312 bytes is larger than 3072 bytes [-Werror=frame-larger-than=] This happens when a sanitizer uses stack memory each time an inline function gets called. This introduces a new annotation for those functions to make them either 'inline' or 'noinline' depending on the CONFIG_KASAN symbol. Signed-off-by: Arnd Bergmann --- include/linux/compiler.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 219f82f3ec1a..a402c43c07d2 100644 --- a/include/linux/compiler.h +++ b/include/linux/compiler.h @@ -412,6 +412,17 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s */ #define noinline_for_stack noinline +/* + * CONFIG_KASAN can lead to extreme stack usage with certain patterns when + * one function gets inlined many times and each instance requires a stack + * ckeck. + */ +#ifdef CONFIG_KASAN +#define noinline_if_stackbloat noinline __maybe_unused +#else +#define noinline_if_stackbloat inline +#endif + #ifndef __always_inline #define __always_inline inline #endif -- 2.9.0