Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752699AbdFNWqH (ORCPT ); Wed, 14 Jun 2017 18:46:07 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:46579 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbdFNWqG (ORCPT ); Wed, 14 Jun 2017 18:46:06 -0400 Subject: Re: [PATCH v2 02/12] ARC: set level of log per CPU during boot to be debug level To: Noam Camus , CC: Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc References: <1497362636-30353-1-git-send-email-noamca@mellanox.com> <1497362636-30353-3-git-send-email-noamca@mellanox.com> From: Vineet Gupta Message-ID: <7f6432b3-a5ea-13ee-e207-1edd0115434a@synopsys.com> Date: Wed, 14 Jun 2017 15:45:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1497362636-30353-3-git-send-email-noamca@mellanox.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.108] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3027 Lines: 87 On 06/13/2017 07:03 AM, Noam Camus wrote: > From: Noam Camus > > The reasons are: > 1) speeding up boot time, becomes critical for many CPUs machine, > e.g. NPS400 with 4K CPUs > 2) shorten kernel log at boot time, again easy to scan for large > scale machines such NPS400 > > Signed-off-by: Noam Camus > --- > arch/arc/kernel/setup.c | 6 +++--- > arch/arc/kernel/smp.c | 4 ++-- > arch/arc/mm/cache.c | 2 +- > arch/arc/mm/tlb.c | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c > index fc8211f..8494b31 100644 > --- a/arch/arc/kernel/setup.c > +++ b/arch/arc/kernel/setup.c > @@ -385,13 +385,13 @@ void setup_processor(void) > read_arc_build_cfg_regs(); > arc_init_IRQ(); > > - printk(arc_cpu_mumbojumbo(cpu_id, str, sizeof(str))); > + pr_debug("%s", arc_cpu_mumbojumbo(cpu_id, str, sizeof(str))); I understand you issue, but as Alexey mentioned before we can't switch the normal kernel boot log to debug only. At best you can convert the current printk to pr_info and then set the log level in your cmdline to something higher than info ! > > arc_mmu_init(); > arc_cache_init(); > > - printk(arc_extn_mumbojumbo(cpu_id, str, sizeof(str))); > - printk(arc_platform_smp_cpuinfo()); > + pr_debug("%s", arc_extn_mumbojumbo(cpu_id, str, sizeof(str))); > + pr_debug("%s", arc_platform_smp_cpuinfo()); > > arc_chk_core_config(); > } > diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c > index f462671..d1aa917 100644 > --- a/arch/arc/kernel/smp.c > +++ b/arch/arc/kernel/smp.c > @@ -177,8 +177,8 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) > > secondary_idle_tsk = idle; > > - pr_info("Idle Task [%d] %p", cpu, idle); > - pr_info("Trying to bring up CPU%u ...\n", cpu); > + pr_debug("Idle Task [%d] %p", cpu, idle); > + pr_debug("Trying to bring up CPU%u ...\n", cpu); > > if (plat_smp_ops.cpu_kick) > plat_smp_ops.cpu_kick(cpu, > diff --git a/arch/arc/mm/cache.c b/arch/arc/mm/cache.c > index a867575..7d3e79b 100644 > --- a/arch/arc/mm/cache.c > +++ b/arch/arc/mm/cache.c > @@ -1188,7 +1188,7 @@ void __ref arc_cache_init(void) > unsigned int __maybe_unused cpu = smp_processor_id(); > char str[256]; > > - printk(arc_cache_mumbojumbo(0, str, sizeof(str))); > + pr_debug("%s", arc_cache_mumbojumbo(0, str, sizeof(str))); > > /* > * Only master CPU needs to execute rest of function: > diff --git a/arch/arc/mm/tlb.c b/arch/arc/mm/tlb.c > index d0126fd..c5e70d8 100644 > --- a/arch/arc/mm/tlb.c > +++ b/arch/arc/mm/tlb.c > @@ -814,7 +814,7 @@ void arc_mmu_init(void) > char str[256]; > struct cpuinfo_arc_mmu *mmu = &cpuinfo_arc700[smp_processor_id()].mmu; > > - printk(arc_mmu_mumbojumbo(0, str, sizeof(str))); > + pr_debug("%s", arc_mmu_mumbojumbo(0, str, sizeof(str))); > > /* > * Can't be done in processor.h due to header include depenedencies >