Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752321AbdFOC3l (ORCPT ); Wed, 14 Jun 2017 22:29:41 -0400 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:54595 "EHLO cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbdFOC3k (ORCPT ); Wed, 14 Jun 2017 22:29:40 -0400 X-RM-TRANSID: 2eeb5941f111ff5-2a14f X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee45941f10fe0b-47e8a From: Haishuang Yan To: "David S. Miller" , Eric Dumazet , Pravin B Shelar , Alexei Starovoitov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Haishuang Yan Subject: [PATCH v4 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv Date: Thu, 15 Jun 2017 10:29:29 +0800 Message-Id: <1497493770-13000-1-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 35 When ip_tunnel_rcv fails, the tun_dst won't be freed, so call dst_release to free it in error code path. Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") Acked-by: Eric Dumazet Acked-by: Pravin B Shelar Tested-by: Zhang Shengju Signed-off-by: Haishuang Yan --- Change since v4: * Add the the missing Fixes information * Free tun_dst from error code path * Add tester information --- net/ipv4/ip_tunnel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index b878ecb..0f1d876 100644 --- a/net/ipv4/ip_tunnel.c +++ b/net/ipv4/ip_tunnel.c @@ -446,6 +446,8 @@ int ip_tunnel_rcv(struct ip_tunnel *tunnel, struct sk_buff *skb, return 0; drop: + if (tun_dst) + dst_release((struct dst_entry *)tun_dst); kfree_skb(skb); return 0; } -- 1.8.3.1