Message-ID: <1497502848.14396.2.camel@perches.com>
Subject: Re: [PATCH] USB: gtco: remove unnecessary variable assignments
From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 14 Jun 2017 22:00:48 -0700
In-Reply-To: <20170615015029.GA5601@embeddedgus>
References: <20170615015029.GA5601@embeddedgus>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 931
Lines: 26

On Wed, 2017-06-14 at 20:50 -0500, Gustavo A. R. Silva wrote:
> Remove unnecessary variable assignments.
> Variable _val_ is overwritten before the value stored in it can be used.
> 
> Addresses-Coverity-ID: 1397695
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/input/tablet/gtco.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
> index b796e89..d9de13c 100644
> --- a/drivers/input/tablet/gtco.c
> +++ b/drivers/input/tablet/gtco.c
> @@ -652,8 +652,6 @@ static void gtco_urb_callback(struct urb *urbinfo)
>  		switch (device->buffer[0]) {
>  		case 5:
>  			/* Pressure is 9 bits */
> -			val = ((u16)(device->buffer[8]) << 1);
> -			val |= (u16)(device->buffer[7] >> 7);
>  			input_report_abs(inputdev, ABS_PRESSURE,
>  					 device->buffer[8]);

Perhaps more likely to be

			input_report_abs(inputdev, ABS_PRESSURE, val);