Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752155AbdFOFTF (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Jun 2017 01:19:05 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:46422 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750776AbdFOFTE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Jun 2017 01:19:04 -0400
Date: Thu, 15 Jun 2017 07:18:55 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: "Edward A. James" <eajames@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, bradleyb@fuzziesquirrel.com,
        jk@ozlabs.org, cbostic@linux.vnet.ibm.com, joel@jms.id.au,
        andrew@aj.id.au
Subject: Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver
Message-ID: <20170615051855.GC28985@kroah.com>
References: <1497469647-4608-1-git-send-email-eajames@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1497469647-4608-1-git-send-email-eajames@us.ibm.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1322
Lines: 40

On Wed, Jun 14, 2017 at 02:47:27PM -0500, Edward A. James wrote:
> --- /dev/null
> +++ b/include/linux/fsi-sbefifo.h
> @@ -0,0 +1,30 @@
> +/*
> + * SBEFIFO FSI Client device driver
> + *
> + * Copyright (C) IBM Corporation 2017
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERGCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef LINUX_FSI_SBEFIFO_H
> +#define LINUX_FSI_SBEFIFO_H
> +
> +struct device;
> +struct sbefifo_client;
> +
> +extern struct sbefifo_client *sbefifo_drv_open(struct device *dev,
> +					       unsigned long flags);
> +extern int sbefifo_drv_read(struct sbefifo_client *client, char *buf,
> +			    size_t len);
> +extern int sbefifo_drv_write(struct sbefifo_client *client, const char *buf,
> +			     size_t len);
> +extern void sbefifo_drv_release(struct sbefifo_client *client);
> +
> +#endif /* LINUX_FSI_SBEFIFO_H */

Why do you need this .h file at all?  Nothing is calling it, right?

thanks,

greg k-h