Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752148AbdFOFwT (ORCPT ); Thu, 15 Jun 2017 01:52:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54926 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbdFOFwR (ORCPT ); Thu, 15 Jun 2017 01:52:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 739356075B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [PATCH 10/18] spi: qup: Fix DMA mode interrupt handling To: Andy Gross Cc: Varadarajan Narayanan , broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, david.brown@linaro.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org References: <1497419551-21834-1-git-send-email-varada@codeaurora.org> <1497419551-21834-11-git-send-email-varada@codeaurora.org> <66ba7dfb-6ff3-884e-6db0-8d5191f87c93@codeaurora.org> <20170614200608.GE32733@hector.wework.com> From: Sricharan R Message-ID: <2fa0690c-ee1d-f29b-4bd5-23bbe26aacfc@codeaurora.org> Date: Thu, 15 Jun 2017 11:22:10 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170614200608.GE32733@hector.wework.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2662 Lines: 72 Hi Andy, On 6/15/2017 1:36 AM, Andy Gross wrote: > On Wed, Jun 14, 2017 at 12:51:11PM +0530, Sricharan R wrote: >> Hi Varada, >> >> On 6/14/2017 11:22 AM, Varadarajan Narayanan wrote: >>> This is needed for v1, where the i/o completion is not >>> handled in the dma driver. >>> >>> Signed-off-by: Andy Gross >>> Signed-off-by: Varadarajan Narayanan >>> --- >>> drivers/spi/spi-qup.c | 15 +++++++++++++-- >>> 1 file changed, 13 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c >>> index 872de28..bd53e82 100644 >>> --- a/drivers/spi/spi-qup.c >>> +++ b/drivers/spi/spi-qup.c >>> @@ -510,9 +510,9 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) >>> >>> writel_relaxed(qup_err, controller->base + QUP_ERROR_FLAGS); >>> writel_relaxed(spi_err, controller->base + SPI_ERROR_FLAGS); >>> - writel_relaxed(opflags, controller->base + QUP_OPERATIONAL); >>> >>> if (!xfer) { >>> + writel_relaxed(opflags, controller->base + QUP_OPERATIONAL); >> >> This does look correct to remove acknowledging the QUP in normal case and >> do it conditionally only when xfer = NULL. > > This is to probably mask the issue of getting erroneous/spurious IRQs. > hmm, now the QUP_OPERATIONAL is not written to acknowledge the interrupts in normal case seems to be wrong. >> >>> dev_err_ratelimited(controller->dev, "unexpected irq %08x %08x %08x\n", >>> qup_err, spi_err, opflags); >>> return IRQ_HANDLED; >>> @@ -540,7 +540,15 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) >>> error = -EIO; >>> } >>> >>> - if (!spi_qup_is_dma_xfer(controller->mode)) { >>> + if (spi_qup_is_dma_xfer(controller->mode)) { >>> + writel_relaxed(opflags, controller->base + QUP_OPERATIONAL); >>> + if (opflags & QUP_OP_IN_SERVICE_FLAG && >>> + opflags & QUP_OP_MAX_INPUT_DONE_FLAG) >>> + complete(&controller->rxc); >>> + if (opflags & QUP_OP_OUT_SERVICE_FLAG && >>> + opflags & QUP_OP_MAX_OUTPUT_DONE_FLAG) >>> + complete(&controller->txc); >>> + } else { >> >> Is this because in patch #8 that we do not populate the dma callback >> for v1. If that is done, this should not be required at all, as the >> complete would be signalled from the dma callback. > > I believe that is true. There shouldn't be any IRQs for DMA enabled > transactions (at least BAM-dma). yeah, the above hunk looks like is ADM specific, not sure why ADM cannot work with dma callbacks. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation