Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbdFOGsn (ORCPT ); Thu, 15 Jun 2017 02:48:43 -0400 Received: from ozlabs.org ([103.22.144.67]:46873 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbdFOGsm (ORCPT ); Thu, 15 Jun 2017 02:48:42 -0400 From: Michael Ellerman To: Guenter Roeck , Frank Rowand Cc: linux-kernel@vger.kernel.org, Rob Herring Subject: Re: Qemu crashes in -next due to 'of: remove *phandle properties from expanded device tree' In-Reply-To: <20170614192638.GA15210@roeck-us.net> References: <20170614192638.GA15210@roeck-us.net> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 15 Jun 2017 16:48:40 +1000 Message-ID: <87efulpwzb.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2489 Lines: 52 Guenter Roeck writes: > Hi Frank, > > your commit 'of: remove *phandle properties from expanded device tree' in > -next causes several of my ppc qemu tests to crash. Looking into qemu, it > sets "linux,phandle" properties for the mpic and for other devices. Yeah this broke ~50% of my machines. Various back traces, or in some cases nothing at all. cheers eg: XICS: Cannot find a Source Controller ! ------------[ cut here ]------------ kernel BUG at arch/powerpc/sysdev/xics/xics-common.c:58! Oops: Exception in kernel mode, sig: 5 [#1] SMP NR_CPUS=2048 NUMA pSeries Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 4.12.0-rc5-gcc5-next-20170614-gb147461 #1 task: c000000000eb1180 task.stack: c000000001084000 NIP: c00000000008d780 LR: c00000000008d770 CTR: 0000000000000000 REGS: c000000001087a40 TRAP: 0700 Tainted: G W (4.12.0-rc5-gcc5-next-20170614-gb147461) MSR: 8000000000021032 CR: 24000422 XER: 00000001 CFAR: c0000000008dd280 SOFTE: 0 GPR00: c00000000008d770 c000000001087cc0 c000000001086400 0000000000000000 GPR04: 0000000000000000 0000000000000000 c000000000ad14c8 0000000000000002 GPR08: 0000000000000002 0000000000000001 0000000000000002 0000000000000000 GPR12: 0000000022000424 c000000006af0000 00000000054dd288 00000000054b5618 GPR16: 00000000054b5320 00000000054b59e8 000000000554dd20 0000000000000060 GPR20: 000000000462eea0 0000000001b56c80 0000000000000040 0000000000000000 GPR24: 0000000004814000 0000000005aa0028 0000000004814000 0000000005ab158e GPR28: ffffffffd00dfeed c000000000e115e0 0000000000000000 c000000000eb54f4 NIP [c00000000008d780] .xics_update_irq_servers+0x40/0x140 LR [c00000000008d770] .xics_update_irq_servers+0x30/0x140 Call Trace: [c000000001087cc0] [c00000000008d770] .xics_update_irq_servers+0x30/0x140 (unreliable) [c000000001087d50] [c000000000db85f0] .xics_init+0x134/0x188 [c000000001087dd0] [c000000000dbdc64] .pseries_init_irq+0x48/0x230 [c000000001087e80] [c000000000da8dcc] .init_IRQ+0x3c/0x50 [c000000001087ef0] [c000000000da44e4] .start_kernel+0x31c/0x528 [c000000001087f90] [c00000000000b070] start_here_common+0x1c/0x4ac Instruction dump: f821ff71 60000000 60000000 3d02ffe3 38800000 3be8f0f4 e87f0002 4884fa85 60000000 7c690074 7c7e1b78 7929d182 <0b090000> e93f0002 3d02000b 3c82ffc2 ---[ end trace 523b05d3a02887f6 ]---